starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4671] [MERGED] Clip text to within the row we expect #25882

New Issue
Open
opened 2026-01-31 09:12:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:12:24 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4671
Author: @miniksa
Created: 2/21/2020
Status: ✅ Merged
Merged: 2/21/2020
Merged by: @undefined

Base: master ← Head: dev/miniksa/draw3

📝 Commits (3)

  • 6a4347e Clip text to within the row we expect.
  • dc419da noexcept!!!!
  • 94d0ec8 Merge branch 'master' into dev/miniksa/draw3

📊 Changes

2 files changed (+13 additions, -0 deletions)

View changed files

📝 OpenConsole.sln (+6 -0)
📝 src/renderer/dx/CustomTextRenderer.cpp (+7 -0)

📄 Description

Summary of the Pull Request

Adjusts DrawGlyphRun method inside DirectX renderer to restrict text
to be clipped within the boundaries of the row.

PR Checklist

Detailed Description of the Pull Request / Additional comments

For whatever reason, some of these shade glyphs near U+2591 tend to
extend way above the height of where we expect they should. This didn't
look like a problem in conhost because it clipped every draw inside the
bounds. This therefore applies the same clip logic as people don't
really expect text to pour out of the box.

It could, theoretically, get us into trouble later should someone
attempt zalgo text. But doing zalgo text is more of a silliness that
varies in behavior across rendering platforms anyway.

Validation Steps Performed

  • Ran the old conhost GDI renderer and observed
  • Ran the new Terminal DX renderer and observed
  • Made the code change
  • Observed that the height and approximate display characteristics of
    the U+2591 shade and neighboring characters now matches with the conhost
    GDI style to stay within its lane.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4671 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 2/21/2020 **Status:** ✅ Merged **Merged:** 2/21/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/miniksa/draw3` --- ### 📝 Commits (3) - [`6a4347e`](https://github.com/microsoft/terminal/commit/6a4347ea71af6cb35de7e4026812fa5b1b09a584) Clip text to within the row we expect. - [`dc419da`](https://github.com/microsoft/terminal/commit/dc419daf49eff04ff26300499960ca61de2497fe) noexcept!!!! - [`94d0ec8`](https://github.com/microsoft/terminal/commit/94d0ec8a5c19241abb2cbd55c1b9bb5c7f1c98ee) Merge branch 'master' into dev/miniksa/draw3 ### 📊 Changes **2 files changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+6 -0) 📝 `src/renderer/dx/CustomTextRenderer.cpp` (+7 -0) </details> ### 📄 Description ## Summary of the Pull Request Adjusts `DrawGlyphRun` method inside DirectX renderer to restrict text to be clipped within the boundaries of the row. ## PR Checklist * [x] Closes #1703 * [x] I work here. * [x] No tests. * [x] No docs. * [x] I am core contributor. ## Detailed Description of the Pull Request / Additional comments For whatever reason, some of these shade glyphs near U+2591 tend to extend way above the height of where we expect they should. This didn't look like a problem in conhost because it clipped every draw inside the bounds. This therefore applies the same clip logic as people don't really expect text to pour out of the box. It could, theoretically, get us into trouble later should someone attempt zalgo text. But doing zalgo text is more of a silliness that varies in behavior across rendering platforms anyway. ## Validation Steps Performed - Ran the old conhost GDI renderer and observed - Ran the new Terminal DX renderer and observed - Made the code change - Observed that the height and approximate display characteristics of the U+2591 shade and neighboring characters now matches with the conhost GDI style to stay within its lane. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25882
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?