starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4714] [MERGED] Accept String value for Keybindings's Keys #25892

New Issue
Open
opened 2026-01-31 09:12:29 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:12:29 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4714
Author: @carlos-zamora
Created: 2/25/2020
Status: ✅ Merged
Merged: 2/27/2020
Merged by: @undefined

Base: master ← Head: dev/cazamor/accept-string-keybinding

📝 Commits (5)

📊 Changes

5 files changed (+114 additions, -60 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+16 -6)
📝 doc/user-docs/UsingJsonSettings.md (+19 -2)
📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+25 -0)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+4 -2)
📝 src/cascadia/TerminalApp/defaults.json (+50 -50)

📄 Description

Summary of the Pull Request

keys in keybindings now accepts a string value. This assumes that you wanted a keychord of size 1. The schema and user docs were properly updated too.

This means that the following keybinding is now accepted in your profiles.json:

{ "command": "copy", "keys": "ctrl+c" }

as opposed to...

{ "command": "copy", "keys": [ "ctrl+c" ] }

PR Checklist

Validation Steps Performed

  • tested the new schema
  • added test

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4714 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 2/25/2020 **Status:** ✅ Merged **Merged:** 2/27/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/accept-string-keybinding` --- ### 📝 Commits (5) - [`d4ef1cb`](https://github.com/microsoft/terminal/commit/d4ef1cb5065f8565a409546a0473cce047d351c0) Accept keybindings.keys string - [`372270a`](https://github.com/microsoft/terminal/commit/372270a2f25489eb71845bd10df4b7c70125737c) add test - [`5748502`](https://github.com/microsoft/terminal/commit/5748502358a9866cffc218449a47cc72632887da) code format - [`968b20d`](https://github.com/microsoft/terminal/commit/968b20d05a9e859d05dcd0e0eebe78f567e0b65d) split if-statement for clarity and functionality - [`83d2b2c`](https://github.com/microsoft/terminal/commit/83d2b2c2e93cc1a673aa06cd53f41bd52138f90f) update defaults.json & docs ### 📊 Changes **5 files changed** (+114 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+16 -6) 📝 `doc/user-docs/UsingJsonSettings.md` (+19 -2) 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+25 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+4 -2) 📝 `src/cascadia/TerminalApp/defaults.json` (+50 -50) </details> ### 📄 Description ## Summary of the Pull Request `keys` in `keybindings` now accepts a string value. This assumes that you wanted a keychord of size 1. The schema and user docs were properly updated too. This means that the following keybinding is now accepted in your profiles.json: ```json { "command": "copy", "keys": "ctrl+c" } ``` as opposed to... ```json { "command": "copy", "keys": [ "ctrl+c" ] } ``` ## PR Checklist * [X] Closes #4713 * [X] CLA signed. * [X] Tests added/passed * [X] Requires documentation to be updated ## Validation Steps Performed - [X] tested the new schema - [X] added test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?