starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4756] [MERGED] AzCon: improve input, usability, reliability (4 commits) #25934

New Issue
Open
opened 2026-01-31 09:12:47 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:12:47 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4756
Author: @DHowett-MSFT
Created: 2/29/2020
Status: ✅ Merged
Merged: 3/4/2020
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/azure_2

📝 Commits (4)

  • f331572 Azure: rewrite user input handler
  • 3a96cda Azure: display the user's options and additional information in color
  • 8eaeff4 Azure: follow the user's shell choice from the online portal
  • daf32ee Azure: remove all credentials instead of just the first one

📊 Changes

3 files changed (+234 additions, -191 deletions)

View changed files

📝 src/cascadia/TerminalConnection/AzureConnection.cpp (+206 -166)
📝 src/cascadia/TerminalConnection/AzureConnection.h (+15 -12)
📝 src/cascadia/TerminalConnection/Resources/Resources.language-en.resw (+13 -13)

📄 Description

This pull request comprises four commits that improve the Azure connection.

Azure: rewrite user input handler

This commit replaces the AzureConnection's input handler with one that
acts more like "getline()". Instead of the Read thread setting a state
and WriteInput filling in the right member variable, the reader blocks
on the user's input and receives it in an optional.

This moves the input number parsing and error case handling closer to
the point where those inputs are used, as opposed to where they're
collected.

It also switches our input to be "line-based", which is a huge boon for
typing tenant numbers >9. This fixes #3233. A simple line editor
(supporting only backspace and CR) is included.

It also enables echo on user input, and prints it in a nice pretty green
color.

It also enables input queueing: if the user types anything before the
connection is established, it'll be sent once it is.

Fixes #3233.

Azure: display the user's options and additional information in color

This commit colorizes parts of the AzCon's strings that include "user
options" -- things the user can type -- in yellow. This is to help with
accessibility.

The implementation here is based on a discussion with the team.
Alternative options for coloration were investigated, such as:

  • Embedding escape sequences in the resource file.
    This would have been confusing for translators.
    The RESW file format doesn't support  escapes, so we would need
    some magic post-processing.
  • Embedding "markup" in the resource file (like #{93m}, ...)
    This still would have been annoying for translators.

We settled on an implementation that takes resource names, colorizes
them, and string-formats them into other resources.

Azure: follow the user's shell choice from the online portal

Fixes #2266.

Azure: remove all credentials instead of just the first one

just a silly bug.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4756 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 2/29/2020 **Status:** ✅ Merged **Merged:** 3/4/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/azure_2` --- ### 📝 Commits (4) - [`f331572`](https://github.com/microsoft/terminal/commit/f331572d7dd6942ed84f828c02dec821f88e6714) Azure: rewrite user input handler - [`3a96cda`](https://github.com/microsoft/terminal/commit/3a96cda8196049aded273d2ba32ac6686a0ac48a) Azure: display the user's options and additional information in color - [`8eaeff4`](https://github.com/microsoft/terminal/commit/8eaeff4b6aa11591f8832e3d3b3e787b55ff0e4f) Azure: follow the user's shell choice from the online portal - [`daf32ee`](https://github.com/microsoft/terminal/commit/daf32ee185126064bbef2d4b0ab41a67087a9897) Azure: remove all credentials instead of just the first one ### 📊 Changes **3 files changed** (+234 additions, -191 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalConnection/AzureConnection.cpp` (+206 -166) 📝 `src/cascadia/TerminalConnection/AzureConnection.h` (+15 -12) 📝 `src/cascadia/TerminalConnection/Resources/Resources.language-en.resw` (+13 -13) </details> ### 📄 Description This pull request comprises four commits that improve the Azure connection. ## Azure: rewrite user input handler This commit replaces the AzureConnection's input handler with one that acts more like "getline()". Instead of the Read thread setting a state and WriteInput filling in the right member variable, the reader blocks on the user's input and receives it in an optional<string>. This moves the input number parsing and error case handling closer to the point where those inputs are used, as opposed to where they're collected. It also switches our input to be "line-based", which is a huge boon for typing tenant numbers >9. This fixes #3233. A simple line editor (supporting only backspace and CR) is included. It also enables echo on user input, and prints it in a nice pretty green color. It also enables input queueing: if the user types anything before the connection is established, it'll be sent once it is. Fixes #3233. ## Azure: display the user's options and additional information in color This commit colorizes parts of the AzCon's strings that include "user options" -- things the user can type -- in yellow. This is to help with accessibility. The implementation here is based on a discussion with the team. Alternative options for coloration were investigated, such as: * Embedding escape sequences in the resource file. This would have been confusing for translators. The RESW file format doesn't support &amp;#x1B; escapes, so we would need some magic post-processing. * Embedding "markup" in the resource file (like #{93m}, ...) This still would have been annoying for translators. We settled on an implementation that takes resource names, colorizes them, and string-formats them into other resources. ## Azure: follow the user's shell choice from the online portal Fixes #2266. ## Azure: remove all credentials instead of just the first one just a silly bug. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25934
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?