starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4805] [MERGED] Polish AutomationProperties and UIA Tree Navigation #25953

New Issue
Open
opened 2026-01-31 09:12:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:12:53 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4805
Author: @carlos-zamora
Created: 3/4/2020
Status: ✅ Merged
Merged: 3/5/2020
Merged by: @undefined

Base: master ← Head: dev/cazamor/acc/nav

📝 Commits (8)

  • 0a69e74 fix UIA tree nav for tab row + TSF
  • f524036 Remove images, icons, and min/max/close button from UIA Tree
  • a2926fb Add AutoProperty for Search Box close button
  • 6d442c1 remove Tab AutomationProperty Setter that doesn't work :(
  • d22db50 remove TabView changes that don't actually work
  • 0d2ed30 Dustin's Formatting - Part 1
  • abf24a0 Dustin's Formatting - Part 2
  • b312292 localize MinMaxClose AutoProp Name

📊 Changes

8 files changed (+73 additions, -37 deletions)

View changed files

📝 src/cascadia/TerminalApp/MinMaxCloseControl.xaml (+18 -6)
📝 src/cascadia/TerminalApp/Resources/Resources.language-en.resw (+43 -28)
📝 src/cascadia/TerminalApp/TabRowControl.xaml (+3 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+1 -0)
📝 src/cascadia/TerminalApp/lib/pch.h (+1 -0)
📝 src/cascadia/TerminalControl/Resources/Resources.language-en.resw (+3 -0)
📝 src/cascadia/TerminalControl/TSFInputControl.xaml (+2 -1)
📝 src/cascadia/TerminalControl/TermControl.xaml (+2 -1)

📄 Description

AutomationProperties of interest in this PR include...

  • Name: the name of a UI element (generally used as the main identifier
    for it)
  • HelpText: an additional description for a more complex UI element
  • AccessibilityView[1]
    • Raw: hide from the UIA tree. Only navigate to this if you know what
      you're doing
    • Control: a control without any content in it. Basically, a point at
      which the user can make a decision as to how to navigate the tree or
      invoke an action.
    • Content: a control that also has content to present to the user.

I set a few more AutomationProperties throughout Windows Terminal...

  • MinMaxClose Control: hidden (we can/should rely on the true buttons
    that we are hiding)
  • SplitButton: Name and Help text (currently ignored due to #4804, but
    having it in the resource file won't cause any problems)
  • SearchBox: added a more specific name to the close button
  • BackgroundImage: hide it

References

A few additional work items have been created for tracking...

PR Checklist

Validation Steps Performed

Verified using Accessibility Insights and Inspect.exe

[1] https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-treeoverview

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4805 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 3/4/2020 **Status:** ✅ Merged **Merged:** 3/5/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/acc/nav` --- ### 📝 Commits (8) - [`0a69e74`](https://github.com/microsoft/terminal/commit/0a69e740e094d370bb193b125d46e5205fbc1801) fix UIA tree nav for tab row + TSF - [`f524036`](https://github.com/microsoft/terminal/commit/f524036442062628a3f2529678781adf717d7ef8) Remove images, icons, and min/max/close button from UIA Tree - [`a2926fb`](https://github.com/microsoft/terminal/commit/a2926fb856530218d14209accc0138b6b471a754) Add AutoProperty for Search Box close button - [`6d442c1`](https://github.com/microsoft/terminal/commit/6d442c1b35b527426383390602aaa662880f2343) remove Tab AutomationProperty Setter that doesn't work :( - [`d22db50`](https://github.com/microsoft/terminal/commit/d22db50f7cb55222efaf65f12ab15352424e096d) remove TabView changes that don't actually work - [`0d2ed30`](https://github.com/microsoft/terminal/commit/0d2ed30ef1c5c2a7d84f9829ee47b982b304d9f5) Dustin's Formatting - Part 1 - [`abf24a0`](https://github.com/microsoft/terminal/commit/abf24a00e81b96d3f9ddb231e0660832a0b398d4) Dustin's Formatting - Part 2 - [`b312292`](https://github.com/microsoft/terminal/commit/b312292c06b1fd61aa82a54c447e30d197ff6339) localize MinMaxClose AutoProp Name ### 📊 Changes **8 files changed** (+73 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/MinMaxCloseControl.xaml` (+18 -6) 📝 `src/cascadia/TerminalApp/Resources/Resources.language-en.resw` (+43 -28) 📝 `src/cascadia/TerminalApp/TabRowControl.xaml` (+3 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+1 -0) 📝 `src/cascadia/TerminalApp/lib/pch.h` (+1 -0) 📝 `src/cascadia/TerminalControl/Resources/Resources.language-en.resw` (+3 -0) 📝 `src/cascadia/TerminalControl/TSFInputControl.xaml` (+2 -1) 📝 `src/cascadia/TerminalControl/TermControl.xaml` (+2 -1) </details> ### 📄 Description AutomationProperties of interest in this PR include... - Name: the name of a UI element (generally used as the main identifier for it) - HelpText: an additional description for a more complex UI element - AccessibilityView[1] - Raw: hide from the UIA tree. Only navigate to this if you know what you're doing - Control: a control without any content in it. Basically, a point at which the user can make a decision as to how to navigate the tree or invoke an action. - Content: a control that also has content to present to the user. I set a few more AutomationProperties throughout Windows Terminal... - MinMaxClose Control: hidden (we can/should rely on the true buttons that we are hiding) - SplitButton: Name and Help text (currently ignored due to #4804, but having it in the resource file won't cause any problems) - SearchBox: added a more specific name to the close button - BackgroundImage: hide it ## References A few additional work items have been created for tracking... - SplitButton: https://github.com/microsoft/terminal/issues/4804 ## PR Checklist * [X] Closes #2099 * [X] Closes #2102 ## Validation Steps Performed Verified using Accessibility Insights and Inspect.exe [1] https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-treeoverview --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25953
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?