[PR #4829] [MERGED] Resize the drag bar on WM_DISPLAYCHANGE #25963

Open
opened 2026-01-31 09:12:56 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4829
Author: @zadjii-msft
Created: 3/6/2020
Status: Merged
Merged: 3/6/2020
Merged by: @DHowett-MSFT

Base: masterHead: dev/migrie/b/4166-WM_DISPLAYCHANGE


📝 Commits (1)

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+5 -0)

📄 Description

Summary of the Pull Request

Pretty straightforward. When we get a WM_DISPLAYCHANGE, that means the display's DPI changed. When that happens, resize the drag bar, so that it'll reflect the new scaling.

References

I'm doing this to unblock #4778

PR Checklist

Validation Steps Performed

Man I've changed the DPI of my displays so many times in the last 30 minutes. I draged the window across a bunch of DPI boundaries too.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4829 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/6/2020 **Status:** ✅ Merged **Merged:** 3/6/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/migrie/b/4166-WM_DISPLAYCHANGE` --- ### 📝 Commits (1) - [`2d792bb`](https://github.com/microsoft/terminal/commit/2d792bbbc55cec3bf5bb824c81bf6ae38d76bcb3) This one was easy ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+5 -0) </details> ### 📄 Description ## Summary of the Pull Request Pretty straightforward. When we get a `WM_DISPLAYCHANGE`, that means the display's DPI changed. When that happens, resize the drag bar, so that it'll reflect the new scaling. ## References I'm doing this to unblock #4778 ## PR Checklist * [x] Closes #4166 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Man I've changed the DPI of my displays so many times in the last 30 minutes. I draged the window across a bunch of DPI boundaries too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:56 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25963