starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4819] [MERGED] Ignore right-click copy when copy on select is enabled #25965

New Issue
Open
opened 2026-01-31 09:12:57 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:12:57 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4819
Author: @leonMSFT
Created: 3/6/2020
Status: ✅ Merged
Merged: 3/10/2020
Merged by: @undefined

Base: master ← Head: dev/lelian/cos

📝 Commits (4)

  • 611b0bb Fix right click copy on select on pointer release
  • ad34d91 a better way of checking for pointer release type
  • 9d7e99a adding more comments
  • 58bb3a5 comments and clarifications

📊 Changes

2 files changed (+37 additions, -42 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+33 -39)
📝 src/cascadia/TerminalControl/TermControl.h (+4 -3)

📄 Description

Summary of the Pull Request

Right clicking on a focused tab while Copy On Select is active currently copies any active selection. This is because PointerReleasedHandler doesn't check for the mouse button that was released.
During a mouse button release, only the left mouse button release should be doing anything.

PR Checklist

Validation Steps Performed

These are the scenarios I've tested. They're a combination of in focus/out of focus, Copy On Select on/off, left/right click pressed and their move and release variants.

From Out of Focus:

  • Left Click = Focus
  • Left Click Move = Focus + Selection
  • Left Click Release
    • CoS on = Copy
    • CoS off = Nothing
  • Shift Left Click = Focus
  • Right Click
    • Focus
    • CoS on = Paste
    • CoS off = Copy if Active Selection, Paste if not.
  • Right Click Move = Nothing
  • Right Click Release = Nothing

From In Focus

  • Left Click = Selection if CoS off
  • Left Click Move = Selection
  • Left Click Release
    • CoS on = Copy
    • CoS off = Nothing
  • Shift Left Click = Set Selection Anchor
  • Right Click
    • CoS on = Paste
    • CoS off = Copy if Active Selection, Paste if not.
  • Right Click Move = Nothing
  • Right Click Release = Nothing

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4819 **Author:** [@leonMSFT](https://github.com/leonMSFT) **Created:** 3/6/2020 **Status:** ✅ Merged **Merged:** 3/10/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/lelian/cos` --- ### 📝 Commits (4) - [`611b0bb`](https://github.com/microsoft/terminal/commit/611b0bb63395d62952b341648690eb2036c9e4a5) Fix right click copy on select on pointer release - [`ad34d91`](https://github.com/microsoft/terminal/commit/ad34d912686951a29bf713d5e53ed6a70b6ce393) a better way of checking for pointer release type - [`9d7e99a`](https://github.com/microsoft/terminal/commit/9d7e99ab146351b74373434bf8ddab1da5c1c5bd) adding more comments - [`58bb3a5`](https://github.com/microsoft/terminal/commit/58bb3a5c6a7e3abdbf37ea888a01bb7de6ea225e) comments and clarifications ### 📊 Changes **2 files changed** (+37 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+33 -39) 📝 `src/cascadia/TerminalControl/TermControl.h` (+4 -3) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Right clicking on a focused tab while Copy On Select is active currently copies any active selection. This is because `PointerReleasedHandler` doesn't check for the mouse button that was released. During a mouse button release, only the left mouse button release should be doing anything. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #4740 * [x] CLA signed. * [x] Tests added/passed <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed These are the scenarios I've tested. They're a combination of in focus/out of focus, Copy On Select on/off, left/right click pressed and their move and release variants. From Out of Focus: - Left Click = Focus - Left Click Move = Focus + Selection - Left Click Release - CoS on = Copy - CoS off = Nothing - Shift Left Click = Focus - Right Click - Focus - CoS on = Paste - CoS off = Copy if Active Selection, Paste if not. - Right Click Move = Nothing - Right Click Release = Nothing From In Focus - Left Click = Selection if CoS off - Left Click Move = Selection - Left Click Release - CoS on = Copy - CoS off = Nothing - Shift Left Click = Set Selection Anchor - Right Click - CoS on = Paste - CoS off = Copy if Active Selection, Paste if not. - Right Click Move = Nothing - Right Click Release = Nothing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25965
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?