[PR #4848] [MERGED] Move MouseInput from TermAdapter to TermInput #25974

Open
opened 2026-01-31 09:13:02 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4848
Author: @carlos-zamora
Created: 3/9/2020
Status: Merged
Merged: 3/12/2020
Merged by: @undefined

Base: masterHead: dev/cazamor/vtmm/mouse-input


📝 Commits (7)

  • dfecb2f Copy MouseInput to TerminalInput
  • d2016e0 Fully remove MouseInput and use TerminalInput
  • 7e25e6a code format + static analysis fix
  • df35803 add TODO and missing onecore ifdef
  • 41129e5 remove duplicate TerminalInput. Always use the InputBuffer's
  • fb6e6ba update sources and fix conhost build failure
  • 863fab4 fix conhost

📊 Changes

18 files changed (+299 additions, -354 deletions)

View changed files

📝 src/host/consoleInformation.cpp (+0 -13)
📝 src/host/getset.cpp (+6 -6)
📝 src/host/inputBuffer.cpp (+11 -2)
📝 src/host/inputBuffer.hpp (+6 -0)
📝 src/host/screenInfo.cpp (+2 -2)
📝 src/host/server.h (+0 -5)
📝 src/interactivity/win32/windowio.cpp (+1 -1)
src/terminal/adapter/MouseInput.hpp (+0 -100)
📝 src/terminal/adapter/lib/adapter.vcxproj (+0 -2)
📝 src/terminal/adapter/lib/adapter.vcxproj.filters (+0 -6)
📝 src/terminal/adapter/sources.inc (+0 -1)
📝 src/terminal/adapter/ut_adapter/MouseInputTest.cpp (+5 -5)
📝 src/terminal/input/lib/terminalinput.vcxproj (+4 -2)
📝 src/terminal/input/mouseInput.cpp (+67 -206)
src/terminal/input/mouseInputState.cpp (+115 -0)
📝 src/terminal/input/sources.inc (+2 -0)
📝 src/terminal/input/terminalInput.cpp (+2 -2)
📝 src/terminal/input/terminalInput.hpp (+78 -1)

📄 Description

Summary of the Pull Request

Move the contents and functionality of MouseInput from TerminalAdapter
to TerminalInput.

References

#545 - VT Mouse Mode (Terminal)
#376 - VT Mouse Mode (ConPty)

Detailed Description of the Pull Request / Additional comments

Pretty straightforward. The MouseInput class was a bit large though so I
split it up into a few files. This should make TerminalInput a bit
easier to manage.

  • mouseInputState: enable some of the modes for mouse input. All saved
    to _mouseInputState.
  • mouseInput: basically just HandleMouse() and any helper functions

Validation Steps Performed

Tests should still pass.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4848 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 3/9/2020 **Status:** ✅ Merged **Merged:** 3/12/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/vtmm/mouse-input` --- ### 📝 Commits (7) - [`dfecb2f`](https://github.com/microsoft/terminal/commit/dfecb2f3f202aadbe56dbcbf7c753a3709410cd2) Copy MouseInput to TerminalInput - [`d2016e0`](https://github.com/microsoft/terminal/commit/d2016e03a6865daa5501a028fa76f48c3ceca204) Fully remove MouseInput and use TerminalInput - [`7e25e6a`](https://github.com/microsoft/terminal/commit/7e25e6af578bd721a8beed6bb92c3a0ec89b9e03) code format + static analysis fix - [`df35803`](https://github.com/microsoft/terminal/commit/df35803146ed969d4b01788cd0ab8ed937277d6d) add TODO and missing onecore ifdef - [`41129e5`](https://github.com/microsoft/terminal/commit/41129e532e6652c425c1e2c58dcafe1148cc07c1) remove duplicate TerminalInput. Always use the InputBuffer's - [`fb6e6ba`](https://github.com/microsoft/terminal/commit/fb6e6bade101e4c610bab82b4a52cd59eae799e6) update sources and fix conhost build failure - [`863fab4`](https://github.com/microsoft/terminal/commit/863fab40841bc4c27be40727949cb9b3c5d4748e) fix conhost ### 📊 Changes **18 files changed** (+299 additions, -354 deletions) <details> <summary>View changed files</summary> 📝 `src/host/consoleInformation.cpp` (+0 -13) 📝 `src/host/getset.cpp` (+6 -6) 📝 `src/host/inputBuffer.cpp` (+11 -2) 📝 `src/host/inputBuffer.hpp` (+6 -0) 📝 `src/host/screenInfo.cpp` (+2 -2) 📝 `src/host/server.h` (+0 -5) 📝 `src/interactivity/win32/windowio.cpp` (+1 -1) ➖ `src/terminal/adapter/MouseInput.hpp` (+0 -100) 📝 `src/terminal/adapter/lib/adapter.vcxproj` (+0 -2) 📝 `src/terminal/adapter/lib/adapter.vcxproj.filters` (+0 -6) 📝 `src/terminal/adapter/sources.inc` (+0 -1) 📝 `src/terminal/adapter/ut_adapter/MouseInputTest.cpp` (+5 -5) 📝 `src/terminal/input/lib/terminalinput.vcxproj` (+4 -2) 📝 `src/terminal/input/mouseInput.cpp` (+67 -206) ➕ `src/terminal/input/mouseInputState.cpp` (+115 -0) 📝 `src/terminal/input/sources.inc` (+2 -0) 📝 `src/terminal/input/terminalInput.cpp` (+2 -2) 📝 `src/terminal/input/terminalInput.hpp` (+78 -1) </details> ### 📄 Description ## Summary of the Pull Request Move the contents and functionality of MouseInput from TerminalAdapter to TerminalInput. ## References #545 - VT Mouse Mode (Terminal) #376 - VT Mouse Mode (ConPty) ## Detailed Description of the Pull Request / Additional comments Pretty straightforward. The MouseInput class was a bit large though so I split it up into a few files. This should make TerminalInput a bit easier to manage. - `mouseInputState`: enable some of the modes for mouse input. All saved to `_mouseInputState`. - `mouseInput`: basically just `HandleMouse()` and any helper functions ## Validation Steps Performed Tests should still pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:02 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25974