[PR #4830] [MERGED] Fix a rampant crash in TSFInputControl when opening new tabs #25975

Open
opened 2026-01-31 09:13:02 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4830
Author: @zadjii-msft
Created: 3/6/2020
Status: Merged
Merged: 3/7/2020
Merged by: @undefined

Base: masterHead: dev/migrie/b/4613-its-nice-to-win-one


📝 Commits (7)

  • 01404a5 This fixes the TSFInputControl crash that's plaguing the team like it's covid-19
  • 64e3427 Try to do a get_weak event, but that's not how this works
  • 1c8c32d ctor the _terminal immediately
  • db09511 Revert "Try to do a get_weak event, but that's not how this works"
  • cc434f5 holy shit this will bluescreen your PC
  • 9faa81a Revert "holy shit this will bluescreen your PC"
  • 265a97c Revert "ctor the _terminal immediately"

📊 Changes

1 file changed (+17 additions, -7 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+17 -7)

📄 Description

Summary of the Pull Request

We're deref'ing a null _terminal. Don't do that. This is a okay fix, mostly to stem the bleeding. @DHowett-MSFT's got a mind for a real fix to #4166, but this isn't it.

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4830 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/6/2020 **Status:** ✅ Merged **Merged:** 3/7/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/4613-its-nice-to-win-one` --- ### 📝 Commits (7) - [`01404a5`](https://github.com/microsoft/terminal/commit/01404a5a8c8883f5fe419a11c8ef7d74506e80ec) This fixes the TSFInputControl crash that's plaguing the team like it's covid-19 - [`64e3427`](https://github.com/microsoft/terminal/commit/64e3427c39a9deb54bd7c2d51b4f42518ffe79b6) Try to do a get_weak event, but that's not how this works - [`1c8c32d`](https://github.com/microsoft/terminal/commit/1c8c32d8be2814437c247eab2e50620069b7f03f) ctor the `_terminal` _immediately_ - [`db09511`](https://github.com/microsoft/terminal/commit/db095111da50ae3dada54a27cec07a7b8f6333b7) Revert "Try to do a get_weak event, but that's not how this works" - [`cc434f5`](https://github.com/microsoft/terminal/commit/cc434f502fd1fc03d4cdf64fba12ebc5032b93bc) holy shit this will bluescreen your PC - [`9faa81a`](https://github.com/microsoft/terminal/commit/9faa81a28f462db7653512dd2509a3f8bf153967) Revert "holy shit this will bluescreen your PC" - [`265a97c`](https://github.com/microsoft/terminal/commit/265a97c989a430207b0c508166f2edb51954c07c) Revert "ctor the `_terminal` _immediately_" ### 📊 Changes **1 file changed** (+17 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+17 -7) </details> ### 📄 Description ## Summary of the Pull Request We're deref'ing a null `_terminal`. Don't do that. This is a _okay_ fix, mostly to stem the bleeding. @DHowett-MSFT's got a mind for a real fix to #4166, but this isn't it. ## PR Checklist * [x] related to #4166 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:02 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25975