starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4857] [MERGED] Reveal the taskbar when the user has the Terminal maximized or fullscreen #25992

New Issue
Open
opened 2026-01-31 09:13:10 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:13:10 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4857
Author: @zadjii-msft
Created: 3/9/2020
Status: ✅ Merged
Merged: 3/10/2020
Merged by: @undefined

Base: master ← Head: dev/migrie/b/1438-autohide-taskbar

📝 Commits (6)

  • 3930001 I think this should fix #1438 but it instead gets rid of the left, right, bottom borders???
  • 7ae1413 Merge remote-tracking branch 'ado/master' into dev/migrie/b/1438-autohide-taskbar
  • be73e70 Cleanup for PR
  • c3a9fe3 Turns out I'm crazy and this is expected behavior.
  • 5c418bb s/Chrom/Chrome/g
  • e615f24 type

📊 Changes

1 file changed (+77 additions, -12 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+77 -12)

📄 Description

Summary of the Pull Request

When we are maximized or fullscreened, check for the presence of the taskbar in auto-hide mode. If the Terminal finds the taskbar on any side of the monitor, adjust our window rect by just a little bit, so that the taskbar can still be revealed by the user mousing over that edge.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Note to future code archeologists:
This doesn't seem to work for fullscreen on the primary display. However, testing a bunch of other apps with fullscreen modes and an auto-hiding taskbar has shown that none of them reveal the taskbar from fullscreen mode. This includes Edge, Firefox, Chrome, Sublime Text, Powerpoint - none seemed to support this.

This does however work fine for maximized.

Validation Steps Performed

I'm maximized and fullscreened the Terminal a lot in the last two days.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4857 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/9/2020 **Status:** ✅ Merged **Merged:** 3/10/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/1438-autohide-taskbar` --- ### 📝 Commits (6) - [`3930001`](https://github.com/microsoft/terminal/commit/3930001c7a2844cc298ecea05b874494cc28e3d3) I think this _should_ fix #1438 but it instead gets rid of the left, right, bottom borders??? - [`7ae1413`](https://github.com/microsoft/terminal/commit/7ae1413179a3db6c87cfe118b4cc3b16bbcb6af3) Merge remote-tracking branch 'ado/master' into dev/migrie/b/1438-autohide-taskbar - [`be73e70`](https://github.com/microsoft/terminal/commit/be73e709d5702ca4fd934e83b5909cc6c3ffc1a8) Cleanup for PR - [`c3a9fe3`](https://github.com/microsoft/terminal/commit/c3a9fe39c4d79ea3042c5d175ce75fb4db91e82b) Turns out I'm crazy and this is expected behavior. - [`5c418bb`](https://github.com/microsoft/terminal/commit/5c418bbaffe434e30591cbfb782719d0706dc22d) s/Chrom/Chrome/g - [`e615f24`](https://github.com/microsoft/terminal/commit/e615f2424a2d08ec5cd5dd8f607061cc30677d0e) type ### 📊 Changes **1 file changed** (+77 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+77 -12) </details> ### 📄 Description ## Summary of the Pull Request When we are maximized or fullscreened, check for the presence of the taskbar in auto-hide mode. If the Terminal finds the taskbar on any side of the monitor, adjust our window rect by just a little bit, so that the taskbar can still be revealed by the user mousing over that edge. ## References ## PR Checklist * [x] Closes #1438 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments Note to future code archeologists: This doesn't seem to work for fullscreen on the primary display. However, testing a bunch of other apps with fullscreen modes and an auto-hiding taskbar has shown that _none_ of them reveal the taskbar from fullscreen mode. This includes Edge, Firefox, Chrome, Sublime Text, Powerpoint - none seemed to support this. This does however work fine for maximized. ## Validation Steps Performed I'm maximized and fullscreened the Terminal a lot in the last two days. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25992
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?