[PR #4874] [MERGED] Prevent tab reordering while elevated #26002

Closed
opened 2026-01-31 09:13:15 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4874
Author: @DHowett-MSFT
Created: 3/10/2020
Status: Merged
Merged: 3/11/2020
Merged by: @undefined

Base: masterHead: dev/duhowett/‾


📝 Commits (1)

  • f86bff2 Prevent tab reordering while elevated

📊 Changes

4 files changed (+44 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppLogic.cpp (+33 -0)
📝 src/cascadia/TerminalApp/AppLogic.h (+2 -0)
📝 src/cascadia/TerminalApp/AppLogic.idl (+1 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+8 -0)

📄 Description

There's a platform limitation that causes us to crash when we rearrange
tabs. Xaml tries to send a drag visual (to wit: a screenshot) to the
drag hosting process, but that process is running at a different IL than
us.

For now, we're disabling elevated drag.

Fixes #3581


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4874 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 3/10/2020 **Status:** ✅ Merged **Merged:** 3/11/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/duhowett/‾` --- ### 📝 Commits (1) - [`f86bff2`](https://github.com/microsoft/terminal/commit/f86bff221d3d8662f52a6444764309d254dcabf3) Prevent tab reordering while elevated ### 📊 Changes **4 files changed** (+44 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+33 -0) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+2 -0) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+1 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+8 -0) </details> ### 📄 Description There's a platform limitation that causes us to crash when we rearrange tabs. Xaml tries to send a drag visual (to wit: a screenshot) to the drag hosting process, but that process is running at a different IL than us. For now, we're disabling elevated drag. Fixes #3581 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:15 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26002