starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4905] [MERGED] Force WslDistroGenerator to timeout after 10s and return Profiles #26019

New Issue
Open
opened 2026-01-31 09:13:25 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:13:25 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4905
Author: @leonMSFT
Created: 3/13/2020
Status: ✅ Merged
Merged: 3/16/2020
Merged by: @undefined

Base: master ← Head: dev/lelian/wsldistrogen

📝 Commits (3)

  • 5d90951 WSLDistroGen timeout after 15s and return profile
  • 7ed6acf wait actually 10s
  • 7d705a6 2s is the sane limit

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalApp/WslDistroGenerator.cpp (+2 -2)

📄 Description

When WSL.exe would hang for users, WslDistroGenerator would also hang
while waiting for its wsl.exe --list call to return. The timeout was
INFINITE in the WaitForSingleObject call, but we should slap a
timeout on it instead (here we choose 2 seconds). In addition, if it
times out, we should also just return profiles and let the Terminal
continue to start up without the WSL distro profiles loaded.

Validation Steps Performed

Made a sleep 30 executable as the command instead, made sure it hit the
WAIT_TIMEOUT and continued to start up without loading my Ubuntu
profile.

Closes #3987

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4905 **Author:** [@leonMSFT](https://github.com/leonMSFT) **Created:** 3/13/2020 **Status:** ✅ Merged **Merged:** 3/16/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/lelian/wsldistrogen` --- ### 📝 Commits (3) - [`5d90951`](https://github.com/microsoft/terminal/commit/5d909512deb62463a4b95ef55c633b85102c8073) WSLDistroGen timeout after 15s and return profile - [`7ed6acf`](https://github.com/microsoft/terminal/commit/7ed6acfa449134f5267d381e6ccbd865ad76852f) wait actually 10s - [`7d705a6`](https://github.com/microsoft/terminal/commit/7d705a6fcd1e734ded8fed3bfe0257c37893fd2e) 2s is the sane limit ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/WslDistroGenerator.cpp` (+2 -2) </details> ### 📄 Description When WSL.exe would hang for users, WslDistroGenerator would also hang while waiting for its `wsl.exe --list` call to return. The timeout was `INFINITE` in the `WaitForSingleObject` call, but we should slap a timeout on it instead (here we choose 2 seconds). In addition, if it times out, we should also just return profiles and let the Terminal continue to start up without the WSL distro profiles loaded. # Validation Steps Performed Made a sleep 30 executable as the command instead, made sure it hit the `WAIT_TIMEOUT` and continued to start up without loading my Ubuntu profile. Closes #3987 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26019
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?