[PR #4904] [MERGED] Always remove the drag bar when entering fullscreen #26020

Open
opened 2026-01-31 09:13:25 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4904
Author: @zadjii-msft
Created: 3/13/2020
Status: Merged
Merged: 3/13/2020
Merged by: @undefined

Base: masterHead: dev/migrie/b/4224-fullscreen-from-maximized


📝 Commits (1)

  • 686716a Always remove the drag bar when entering fullscreen

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+5 -0)

📄 Description

Summary of the Pull Request

When the auto-hide taskbar setting is enabled, then we don't
always get another window message to trigger us to remove the drag bar.
So, make sure to update the size of the drag region here, so that it
definitely goes away.

References

PR Checklist

Validation Steps Performed

Manually tested it


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4904 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/13/2020 **Status:** ✅ Merged **Merged:** 3/13/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/4224-fullscreen-from-maximized` --- ### 📝 Commits (1) - [`686716a`](https://github.com/microsoft/terminal/commit/686716a077b11cba33c97b2f4b8e67c900ed3b00) Always remove the drag bar when entering fullscreen ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+5 -0) </details> ### 📄 Description ## Summary of the Pull Request When the auto-hide taskbar setting is enabled, then we don't always get another window message to trigger us to remove the drag bar. So, make sure to update the size of the drag region here, so that it _definitely_ goes away. ## References ## PR Checklist * [x] Closes #4224 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Manually tested it --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:25 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26020