[PR #4938] [MERGED] Add support for Ctrl+# keys #26029

Open
opened 2026-01-31 09:13:30 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4938
Author: @zadjii-msft
Created: 3/16/2020
Status: Merged
Merged: 3/18/2020
Merged by: @undefined

Base: masterHead: dev/migrie/b/3507-ctrl-#-keys


📝 Commits (4)

📊 Changes

2 files changed (+73 additions, -1 deletions)

View changed files

📝 src/terminal/adapter/ut_adapter/inputTest.cpp (+54 -0)
📝 src/terminal/input/terminalInput.cpp (+19 -1)

📄 Description

Summary of the Pull Request

Fixes the Ctrl+Num keys in both conhost and the Terminal. These keys are supposed to be mapped to specific characters according to this doc. Now we actually handle them correctly.

PR Checklist

Validation Steps Performed

  • Ran test
  • tested in gnome-terminal with showkeys -a
  • tested in conhost with showkeys -a
  • tested in Windows Terminal with showkeys -a

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4938 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/16/2020 **Status:** ✅ Merged **Merged:** 3/18/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/3507-ctrl-#-keys` --- ### 📝 Commits (4) - [`20395de`](https://github.com/microsoft/terminal/commit/20395dedb940103f7e6ca12f51cf1afb08f9976d) This fixes #3507 - [`c1e05fd`](https://github.com/microsoft/terminal/commit/c1e05fd6483d0e339a66aa648d954e7945f2a960) Add a test too - [`22ed84f`](https://github.com/microsoft/terminal/commit/22ed84f6046bd476ff922c3f96f696ff3a0c0f25) Merge branch 'master' into dev/migrie/b/3507-ctrl-#-keys - [`007852a`](https://github.com/microsoft/terminal/commit/007852acbbbe1854c8c9d130f0ce890d2703a22c) fix the test that I broke ### 📊 Changes **2 files changed** (+73 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/terminal/adapter/ut_adapter/inputTest.cpp` (+54 -0) 📝 `src/terminal/input/terminalInput.cpp` (+19 -1) </details> ### 📄 Description ## Summary of the Pull Request Fixes the <kbd>Ctrl+Num</kbd> keys in both conhost and the Terminal. These keys are supposed to be mapped to specific characters according to [this doc](https://vt100.net/docs/vt220-rm/table3-5.html). Now we actually handle them correctly. ## PR Checklist * [x] Closes #3507 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed * Ran test * tested in `gnome-terminal` with `showkeys -a` * tested in conhost with `showkeys -a` * tested in Windows Terminal with `showkeys -a` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26029