[PR #4913] [MERGED] Only passthrough input changes if the client's in VT input mode #26032

Open
opened 2026-01-31 09:13:30 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4913
Author: @zadjii-msft
Created: 3/13/2020
Status: Merged
Merged: 3/13/2020
Merged by: @DHowett-MSFT

Base: masterHead: dev/migrie/b/4911-this-is-a-hack


📝 Commits (3)

  • 66a69cc This is a hack to work around an ssh bug
  • 78b0b06 Fix the test
  • e21e15e Okay clean up the useless member now too

📊 Changes

5 files changed (+57 additions, -65 deletions)

View changed files

📝 src/host/outputStream.cpp (+6 -3)
📝 src/host/outputStream.hpp (+1 -1)
📝 src/terminal/adapter/adaptDispatch.cpp (+47 -52)
📝 src/terminal/adapter/conGetSet.hpp (+1 -1)
📝 src/terminal/adapter/ut_adapter/adapterTest.cpp (+2 -8)

📄 Description

This is a hack to fix #4911. I cannot stress enough that I haven't tested this, but it's 5pm on a Friday here in Wisconsin, and I'm hoping that the rest of the team will validate this 😝


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4913 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/13/2020 **Status:** ✅ Merged **Merged:** 3/13/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/migrie/b/4911-this-is-a-hack` --- ### 📝 Commits (3) - [`66a69cc`](https://github.com/microsoft/terminal/commit/66a69cc249fe0630e6fb93e072ad6b30b460ce10) This is a hack to work around an ssh bug - [`78b0b06`](https://github.com/microsoft/terminal/commit/78b0b063e50666ca212fa22ac9525e4521a6300f) Fix the test - [`e21e15e`](https://github.com/microsoft/terminal/commit/e21e15ef920e88157655c471cdb722fdc9949397) Okay clean up the useless member now too ### 📊 Changes **5 files changed** (+57 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `src/host/outputStream.cpp` (+6 -3) 📝 `src/host/outputStream.hpp` (+1 -1) 📝 `src/terminal/adapter/adaptDispatch.cpp` (+47 -52) 📝 `src/terminal/adapter/conGetSet.hpp` (+1 -1) 📝 `src/terminal/adapter/ut_adapter/adapterTest.cpp` (+2 -8) </details> ### 📄 Description This is a hack to fix #4911. I cannot stress enough that I haven't tested this, but it's 5pm on a Friday here in Wisconsin, and I'm hoping that the rest of the team will validate this 😝 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26032