starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4948] [MERGED] Add explicit to bool operators of Point and Rect #26039

New Issue
Open
opened 2026-01-31 09:13:33 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:13:33 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4948
Author: @carlos-zamora
Created: 3/16/2020
Status: ✅ Merged
Merged: 3/19/2020
Merged by: @undefined

Base: master ← Head: dev/cazamor/til-explicit-bool

📝 Commits (5)

  • 50f41a0 add explicit to bool operators
  • 28c1ac7 add bool to size, remove bool from point
  • 1911ccf missed a constexpr
  • e65af60 idk why I can't write code today
  • 500ccc6 ok. I actually tested this out this time

📊 Changes

5 files changed (+30 additions, -21 deletions)

View changed files

📝 src/inc/til/point.h (+0 -5)
📝 src/inc/til/rectangle.h (+1 -1)
📝 src/inc/til/size.h (+5 -0)
📝 src/til/ut_til/PointTests.cpp (+0 -15)
📝 src/til/ut_til/SizeTests.cpp (+24 -0)

📄 Description

Found a bug where the following won't work:

COORD inclusiveEnd{ _end };

where _end is a til::point.

The only fix for this is to replace these instances with this:

COORD inclusiveEnd = _end;

What was happening in the first notation is the implicit conversion of til::point to bool to SHORT. The constructor for COORD only sees one SHORT so it thinks the value should be the definition for X, and Y should stay as 0. So we end up getting 1, 0.

By adding the explicit keyword to the bool operators, we prevent the accident above from occurring.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4948 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 3/16/2020 **Status:** ✅ Merged **Merged:** 3/19/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/til-explicit-bool` --- ### 📝 Commits (5) - [`50f41a0`](https://github.com/microsoft/terminal/commit/50f41a0fd9d1c95c603b67a442dd2de7c964cdb8) add explicit to bool operators - [`28c1ac7`](https://github.com/microsoft/terminal/commit/28c1ac781f6700f56a5a63e1839e4d02b4639489) add bool to size, remove bool from point - [`1911ccf`](https://github.com/microsoft/terminal/commit/1911ccf612e8afb8dda9aa18a423b68518b35594) missed a constexpr - [`e65af60`](https://github.com/microsoft/terminal/commit/e65af601cd60734078954d0a09181acc08c62673) idk why I can't write code today - [`500ccc6`](https://github.com/microsoft/terminal/commit/500ccc6beeeac23db40954d8110c93587898d437) ok. I actually tested this out this time ### 📊 Changes **5 files changed** (+30 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/inc/til/point.h` (+0 -5) 📝 `src/inc/til/rectangle.h` (+1 -1) 📝 `src/inc/til/size.h` (+5 -0) 📝 `src/til/ut_til/PointTests.cpp` (+0 -15) 📝 `src/til/ut_til/SizeTests.cpp` (+24 -0) </details> ### 📄 Description Found a bug where the following won't work: ```c++ COORD inclusiveEnd{ _end }; ``` where `_end` is a `til::point`. The only fix for this is to replace these instances with this: ```c++ COORD inclusiveEnd = _end; ``` What was happening in the first notation is the implicit conversion of `til::point` to `bool` to `SHORT`. The constructor for COORD only sees one SHORT so it thinks the value should be the definition for X, and Y should stay as 0. So we end up getting `1, 0`. By adding the explicit keyword to the bool operators, we prevent the accident above from occurring. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26039
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?