[PR #4953] Make panes use XAML star sizing #26045

Open
opened 2026-01-31 09:13:35 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/4953

State: closed
Merged: Yes


Summary of the Pull Request

Dustin and Mike had a discussion on star sizing. Mcpiroman connected the dots. I just swooped in and implemented it.

References

https://github.com/microsoft/terminal/issues/3996#issuecomment-566676111
https://github.com/microsoft/terminal/issues/3744#issuecomment-568926636

PR Checklist

Detailed Description of the Pull Request / Additional comments

Star sizing allows us to keep things proportional. Since a 1::1 proportion is the same as a 100::100 proportion, I just went in and added star sizing. In the words of a some dude with a big metal fist, everything is perfectly balanced now.

image

Validation Steps Performed

Verified for vertical, horizontal, and uneven splits.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/4953 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Dustin and Mike had a discussion on star sizing. Mcpiroman connected the dots. I just swooped in and implemented it. ## References https://github.com/microsoft/terminal/issues/3996#issuecomment-566676111 https://github.com/microsoft/terminal/issues/3744#issuecomment-568926636 ## PR Checklist * [X] Closes #3744 ## Detailed Description of the Pull Request / Additional comments Star sizing allows us to keep things proportional. Since a 1::1 proportion is the same as a 100::100 proportion, I just went in and added star sizing. In the words of a some dude with a big metal fist, everything is perfectly balanced now. ![image](https://user-images.githubusercontent.com/11050425/76813679-f7103f00-67b5-11ea-9b5c-d2cc73673aba.png) ## Validation Steps Performed Verified for vertical, horizontal, and uneven splits.
claunia added the pull-request label 2026-01-31 09:13:35 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26045