starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4962] [MERGED] hygiene: change default specifiers of some functions to delete #26051

New Issue
Open
opened 2026-01-31 09:13:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:13:38 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4962
Author: @ghost
Created: 3/17/2020
Status: ✅ Merged
Merged: 3/19/2020
Merged by: @DHowett-MSFT

Base: master ← Head: Modernize-loops

📝 Commits (3)

  • 714124f Update cppwinrt_utils.h
  • 7daf22a Revert "Update cppwinrt_utils.h"
  • edaa24b Change copy constuctors from default to delete

📊 Changes

5 files changed (+14 additions, -14 deletions)

View changed files

📝 src/buffer/out/RowCellIterator.hpp (+1 -1)
📝 src/buffer/out/cursor.h (+1 -1)
📝 src/types/ScreenInfoUiaProviderBase.h (+4 -4)
📝 src/types/UiaTextRangeBase.hpp (+4 -4)
📝 src/types/WindowUiaProviderBase.hpp (+4 -4)

📄 Description

For some functions, the overriding implementation is set to default, but
the deletion is not explicitly set at all. For those functions, I
changed default to delete.

Validation Steps

  • Manual Checking including testing the base and the subclasses.
  • Compiler Refactorings
  • Unit tests passed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4962 **Author:** [@ghost](https://github.com/ghost) **Created:** 3/17/2020 **Status:** ✅ Merged **Merged:** 3/19/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `Modernize-loops` --- ### 📝 Commits (3) - [`714124f`](https://github.com/microsoft/terminal/commit/714124fd3c13fb0f126f5d3771db208748585187) Update cppwinrt_utils.h - [`7daf22a`](https://github.com/microsoft/terminal/commit/7daf22a3b669f4356652a288d198970040deb96e) Revert "Update cppwinrt_utils.h" - [`edaa24b`](https://github.com/microsoft/terminal/commit/edaa24b4285712697a68ab2f4f07d1cb4ef8e5c0) Change copy constuctors from default to delete ### 📊 Changes **5 files changed** (+14 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/RowCellIterator.hpp` (+1 -1) 📝 `src/buffer/out/cursor.h` (+1 -1) 📝 `src/types/ScreenInfoUiaProviderBase.h` (+4 -4) 📝 `src/types/UiaTextRangeBase.hpp` (+4 -4) 📝 `src/types/WindowUiaProviderBase.hpp` (+4 -4) </details> ### 📄 Description For some functions, the overriding implementation is set to default, but the deletion is not explicitly set at all. For those functions, I changed default to delete. ## Validation Steps - Manual Checking including testing the base and the subclasses. - Compiler Refactorings - Unit tests passed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26051
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?