[PR #4991] Properly represent block selections in UIA #26067

Open
opened 2026-01-31 09:13:42 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/4991

State: closed
Merged: Yes


Summary of the Pull Request

Block selections were always read and displayed as line selections in UIA. This fixes that.

PR Checklist

Detailed Description of the Pull Request / Additional comments

  1. Expose IsBlockSelection() via IUiaData
  2. Update the constructor to be able to take in a block selection parameter
  3. Make ScreenInfoUiaProviders pass step 1 output into step 2 constructor
  4. Update all instances of UiaTextRange::GetTextRects() to include this new flag

Validation Steps Performed

Manually tested.
Additional tests would be redundant as GetTextRects() is tested in the text buffer.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/4991 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Block selections were always read and displayed as line selections in UIA. This fixes that. ## PR Checklist * [x] Closes #4509 ## Detailed Description of the Pull Request / Additional comments 1. Expose `IsBlockSelection()` via IUiaData 2. Update the constructor to be able to take in a block selection parameter 3. Make ScreenInfoUiaProviders pass step 1 output into step 2 constructor 4. Update all instances of `UiaTextRange::GetTextRects()` to include this new flag ## Validation Steps Performed Manually tested. Additional tests would be redundant as GetTextRects() is tested in the text buffer.
claunia added the pull-request label 2026-01-31 09:13:42 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26067