[PR #4994] [MERGED] Fix an off-by-one that made us use EL instead of ECH #26070

Open
opened 2026-01-31 09:13:44 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4994
Author: @DHowett-MSFT
Created: 3/18/2020
Status: ✅ Merged
Merged: 3/18/2020
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/vt_off_by_one


📝 Commits (1)

  • e4eefa6 Fix an off-by-one that made us use EL instead of ECH

📊 Changes

2 files changed (+63 additions, -6 deletions)

View changed files

📝 src/host/ut_host/ConptyOutputTests.cpp (+62 -5)
📝 src/renderer/vt/paint.cpp (+1 -1)

📄 Description

When we painted spaces up until the character right before the right
edge of the screen, we would erroneously use Erase in Line instead of
Erase Character due to an off-by-one.

This commit also fixes how we'd crash during a verify failure on the
render thread.

Fixes #4727.

Validation Steps Performed

Unit tests and manual verification.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4994 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 3/18/2020 **Status:** ✅ Merged **Merged:** 3/18/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/vt_off_by_one` --- ### 📝 Commits (1) - [`e4eefa6`](https://github.com/microsoft/terminal/commit/e4eefa6deb4092ac99cf14184246835f1aea017f) Fix an off-by-one that made us use EL instead of ECH ### 📊 Changes **2 files changed** (+63 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/host/ut_host/ConptyOutputTests.cpp` (+62 -5) 📝 `src/renderer/vt/paint.cpp` (+1 -1) </details> ### 📄 Description When we painted spaces up until the character right before the right edge of the screen, we would erroneously use Erase in Line instead of Erase Character due to an off-by-one. This commit also fixes how we'd crash during a verify failure on the render thread. Fixes #4727. ## Validation Steps Performed Unit tests and manual verification. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:44 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26070