[PR #4994] Fix an off-by-one that made us use EL instead of ECH #26075

Open
opened 2026-01-31 09:13:45 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/4994

State: closed
Merged: Yes


When we painted spaces up until the character right before the right
edge of the screen, we would erroneously use Erase in Line instead of
Erase Character due to an off-by-one.

This commit also fixes how we'd crash during a verify failure on the
render thread.

Fixes #4727.

Validation Steps Performed

Unit tests and manual verification.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/4994 **State:** closed **Merged:** Yes --- When we painted spaces up until the character right before the right edge of the screen, we would erroneously use Erase in Line instead of Erase Character due to an off-by-one. This commit also fixes how we'd crash during a verify failure on the render thread. Fixes #4727. ## Validation Steps Performed Unit tests and manual verification.
claunia added the pull-request label 2026-01-31 09:13:45 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26075