[PR #5028] [CLOSED] Switch to the I-beam cursor when hovering over the terminal #26083

Open
opened 2026-01-31 09:13:49 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5028
Author: @DHowett-MSFT
Created: 3/20/2020
Status: Closed

Base: mainHead: dev/duhowett/eyebeam


📝 Commits (7)

  • 0f38659 Switch to the I-beam cursor when hovering over the terminal
  • 2e04851 Fix SA (well, guess what SA was mad about) and format
  • 1ae08d4 Merge remote-tracking branch 'origin/master' into dev/duhowett/eyebeam
  • 6db3c8f Merge remote-tracking branch 'origin' into dev/duhowett/eyebeam
  • 698bca2 Merge remote-tracking branch 'origin/master' into dev/duhowett/eyebeam
  • 61e46e3 whitelist IBeam
  • 34f83a6 Migrate spelling-0.0.19 changes from main

📊 Changes

37 files changed (+1134 additions, -480205 deletions)

View changed files

.github/actions/spell-check/dictionary/dictionary.txt (+0 -479826)
.github/actions/spell-check/dictionary/math.txt (+0 -2)
.github/actions/spell-check/dictionary/microsoft.txt (+0 -7)
.github/actions/spell-check/patterns/patterns.txt (+0 -7)
.github/actions/spell-check/whitelist/README.md (+0 -7)
.github/actions/spell-check/whitelist/web.txt (+0 -3)
.github/actions/spelling/advice.md (+50 -0)
📝 .github/actions/spelling/allow/README.md (+5 -4)
.github/actions/spelling/allow/allow.txt (+77 -0)
.github/actions/spelling/allow/apis.txt (+194 -0)
📝 .github/actions/spelling/allow/chinese.txt (+0 -0)
.github/actions/spelling/allow/colors.txt (+117 -0)
📝 .github/actions/spelling/allow/fonts.txt (+2 -0)
📝 .github/actions/spelling/allow/japanese.txt (+0 -0)
.github/actions/spelling/allow/math.txt (+11 -0)
.github/actions/spelling/allow/microsoft.txt (+78 -0)
📝 .github/actions/spelling/allow/names.txt (+25 -0)
📝 .github/actions/spelling/excludes.txt (+20 -2)
.github/actions/spelling/expect/README.md (+13 -0)
📝 .github/actions/spelling/expect/alphabet.txt (+20 -6)

...and 17 more files

📄 Description

This commit makes us use the I-beam cursor when the user hovers over the
terminal, unless mouse mode is enabled. I've also plumbed up a bunch
of events so that:

  • If mouse mode is toggled while hovering, the cursor will switch to
    the arrow if it's on or the I-beam if it's off.
  • If you hold down shift to suppress mouse mode, the cursor will switch
    back to the I-beam.

Fixes #1441.

Detailed Description of the Pull Request / Additional comments

It turns out that we're in violation of the Windows human interface guidelines, so that's good.

It also turns out that you cannot set the cursor type of a control -- you actually have to actively set and reset the cursor when the pointer enters or exits.

terminal_mouse
my selection color is bright red to differentiate it from vim's mouse mode selection


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5028 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 3/20/2020 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/duhowett/eyebeam` --- ### 📝 Commits (7) - [`0f38659`](https://github.com/microsoft/terminal/commit/0f386592e4e17cc7813cb3296894bf5c28a39353) Switch to the I-beam cursor when hovering over the terminal - [`2e04851`](https://github.com/microsoft/terminal/commit/2e04851dc4215199dcc0b83812bb02689a6e1424) Fix SA (well, guess what SA was mad about) and format - [`1ae08d4`](https://github.com/microsoft/terminal/commit/1ae08d41145fb74b2dafc894402774ae4b643bab) Merge remote-tracking branch 'origin/master' into dev/duhowett/eyebeam - [`6db3c8f`](https://github.com/microsoft/terminal/commit/6db3c8f49932cad6f95505b005d268ee920f7cd0) Merge remote-tracking branch 'origin' into dev/duhowett/eyebeam - [`698bca2`](https://github.com/microsoft/terminal/commit/698bca2a491a9fe349e5a65ecfd0e579183d9ed2) Merge remote-tracking branch 'origin/master' into dev/duhowett/eyebeam - [`61e46e3`](https://github.com/microsoft/terminal/commit/61e46e31595da09363c897eaad5f3ec3a07114fa) whitelist IBeam - [`34f83a6`](https://github.com/microsoft/terminal/commit/34f83a60ca13adb6e8dab3ae51ea88b0db456e85) Migrate spelling-0.0.19 changes from main ### 📊 Changes **37 files changed** (+1134 additions, -480205 deletions) <details> <summary>View changed files</summary> ➖ `.github/actions/spell-check/dictionary/dictionary.txt` (+0 -479826) ➖ `.github/actions/spell-check/dictionary/math.txt` (+0 -2) ➖ `.github/actions/spell-check/dictionary/microsoft.txt` (+0 -7) ➖ `.github/actions/spell-check/patterns/patterns.txt` (+0 -7) ➖ `.github/actions/spell-check/whitelist/README.md` (+0 -7) ➖ `.github/actions/spell-check/whitelist/web.txt` (+0 -3) ➕ `.github/actions/spelling/advice.md` (+50 -0) 📝 `.github/actions/spelling/allow/README.md` (+5 -4) ➕ `.github/actions/spelling/allow/allow.txt` (+77 -0) ➕ `.github/actions/spelling/allow/apis.txt` (+194 -0) 📝 `.github/actions/spelling/allow/chinese.txt` (+0 -0) ➕ `.github/actions/spelling/allow/colors.txt` (+117 -0) 📝 `.github/actions/spelling/allow/fonts.txt` (+2 -0) 📝 `.github/actions/spelling/allow/japanese.txt` (+0 -0) ➕ `.github/actions/spelling/allow/math.txt` (+11 -0) ➕ `.github/actions/spelling/allow/microsoft.txt` (+78 -0) 📝 `.github/actions/spelling/allow/names.txt` (+25 -0) 📝 `.github/actions/spelling/excludes.txt` (+20 -2) ➕ `.github/actions/spelling/expect/README.md` (+13 -0) 📝 `.github/actions/spelling/expect/alphabet.txt` (+20 -6) _...and 17 more files_ </details> ### 📄 Description This commit makes us use the I-beam cursor when the user hovers over the terminal, *unless* mouse mode is enabled. I've also plumbed up a bunch of events so that: * If mouse mode is _toggled_ while hovering, the cursor will switch to the arrow if it's on or the I-beam if it's off. * If you hold down shift to suppress mouse mode, the cursor will switch back to the I-beam. Fixes #1441. ## Detailed Description of the Pull Request / Additional comments It turns out that we're in violation of the Windows human interface guidelines, so that's good. It also turns out that _you cannot set the cursor type of a control_ -- you actually have to _actively set and reset the cursor_ when the pointer enters or exits. ![terminal_mouse](https://user-images.githubusercontent.com/14316954/77133462-5f625900-6a20-11ea-98e1-0a37a92c3159.gif) _my selection color is bright red to differentiate it from vim's mouse mode selection_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:49 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26083