starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5080] [MERGED] Replace old C headers (xxx.h) with modern ones (cxxx) #26090

New Issue
Open
opened 2026-01-31 09:13:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:13:52 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5080
Author: @ghost
Created: 3/23/2020
Status: ✅ Merged
Merged: 7/1/2020
Merged by: @DHowett

Base: master ← Head: C-Header

📝 Commits (6)

  • d95be3c Replace deprecated headers with modern ones
  • ed32542 Update cppwinrt_utils.h
  • d6b54ea Revert "Update cppwinrt_utils.h"
  • 87cb794 Update cppwinrt_utils.h
  • 7af6fb8 Revert "Update cppwinrt_utils.h"
  • 5b1ad0b Merge branch 'master' into C-Header

📊 Changes

32 files changed (+71 additions, -64 deletions)

View changed files

📝 .github/actions/spell-check/expect/expect.txt (+7 -0)
📝 samples/ConPTY/EchoCon/EchoCon/stdafx.h (+1 -1)
📝 src/cascadia/TerminalConnection/AzureConnection.cpp (+1 -1)
📝 src/cascadia/WindowsTerminal/pch.h (+2 -2)
📝 src/host/conattrs.cpp (+1 -1)
📝 src/host/precomp.h (+1 -1)
📝 src/host/screenInfo.cpp (+1 -1)
📝 src/host/telemetry.cpp (+1 -1)
📝 src/host/ut_host/UtilsTests.cpp (+1 -1)
📝 src/inc/LibraryIncludes.h (+1 -1)
📝 src/propsheet/precomp.h (+4 -4)
📝 src/renderer/dx/precomp.h (+1 -1)
📝 src/renderer/gdi/precomp.h (+1 -1)
📝 src/renderer/gdi/tool/main.cpp (+2 -2)
📝 src/renderer/vt/precomp.h (+1 -1)
📝 src/renderer/vt/state.cpp (+1 -1)
📝 src/renderer/wddmcon/precomp.h (+1 -1)
📝 src/terminal/adapter/precomp.h (+1 -1)
📝 src/terminal/parser/ft_fuzzer/fuzzing_directed.h (+1 -1)
📝 src/terminal/parser/ft_fuzzer/stdafx.h (+1 -1)

...and 12 more files

📄 Description

Summary of the Pull Request

Most files already have switched to use the modern variation, such as "", "", etc. However, a few files do not, so this PR fixes that.

References

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Unit Tests
  • Followed instructions by the ISO Draft 2005 on C++

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5080 **Author:** [@ghost](https://github.com/ghost) **Created:** 3/23/2020 **Status:** ✅ Merged **Merged:** 7/1/2020 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `master` ← **Head:** `C-Header` --- ### 📝 Commits (6) - [`d95be3c`](https://github.com/microsoft/terminal/commit/d95be3cec3ed0a81d85d86974cf8860b05eb149e) Replace deprecated headers with modern ones - [`ed32542`](https://github.com/microsoft/terminal/commit/ed32542773c1181246bf4b592e1d92d2b3a41e4f) Update cppwinrt_utils.h - [`d6b54ea`](https://github.com/microsoft/terminal/commit/d6b54ea9403b14abfb94ab1512ef915f357a2b30) Revert "Update cppwinrt_utils.h" - [`87cb794`](https://github.com/microsoft/terminal/commit/87cb794b1a59b00963f693dd93b8c83699000eb6) Update cppwinrt_utils.h - [`7af6fb8`](https://github.com/microsoft/terminal/commit/7af6fb85269091d2be994897a5adf5fd6759aef0) Revert "Update cppwinrt_utils.h" - [`5b1ad0b`](https://github.com/microsoft/terminal/commit/5b1ad0b5feeb7ea061990608cb34cd35534b0bfe) Merge branch 'master' into C-Header ### 📊 Changes **32 files changed** (+71 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spell-check/expect/expect.txt` (+7 -0) 📝 `samples/ConPTY/EchoCon/EchoCon/stdafx.h` (+1 -1) 📝 `src/cascadia/TerminalConnection/AzureConnection.cpp` (+1 -1) 📝 `src/cascadia/WindowsTerminal/pch.h` (+2 -2) 📝 `src/host/conattrs.cpp` (+1 -1) 📝 `src/host/precomp.h` (+1 -1) 📝 `src/host/screenInfo.cpp` (+1 -1) 📝 `src/host/telemetry.cpp` (+1 -1) 📝 `src/host/ut_host/UtilsTests.cpp` (+1 -1) 📝 `src/inc/LibraryIncludes.h` (+1 -1) 📝 `src/propsheet/precomp.h` (+4 -4) 📝 `src/renderer/dx/precomp.h` (+1 -1) 📝 `src/renderer/gdi/precomp.h` (+1 -1) 📝 `src/renderer/gdi/tool/main.cpp` (+2 -2) 📝 `src/renderer/vt/precomp.h` (+1 -1) 📝 `src/renderer/vt/state.cpp` (+1 -1) 📝 `src/renderer/wddmcon/precomp.h` (+1 -1) 📝 `src/terminal/adapter/precomp.h` (+1 -1) 📝 `src/terminal/parser/ft_fuzzer/fuzzing_directed.h` (+1 -1) 📝 `src/terminal/parser/ft_fuzzer/stdafx.h` (+1 -1) _...and 12 more files_ </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Most files already have switched to use the modern variation, such as "", "", etc. However, a few files do not, so this PR fixes that. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - Unit Tests - Followed instructions by the ISO Draft 2005 on C++ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26090
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?