[PR #5107] [MERGED] doc: add cmder icon to ThirdPartyToolProfiles #26109

Open
opened 2026-01-31 09:13:58 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5107
Author: @dominik-ba
Created: 3/24/2020
Status: Merged
Merged: 3/24/2020
Merged by: @DHowett-MSFT

Base: masterHead: patch-1


📝 Commits (2)

  • 99789ba adding cmder icon to ThirdPartyToolProfiles
  • 6844d26 Update doc/user-docs/ThirdPartyToolProfiles.md

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 doc/user-docs/ThirdPartyToolProfiles.md (+1 -0)

📄 Description

Simply adding the icon property to the ThirdPartyToolProfiles examples md for cmder

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I think not much detail needed since this only an update to a doc and not the main application.

Validation Steps Performed

I tried it locally and worked without any adjustments to the cmder folder. Just making sure (as already stated) the %CMDER_ROOT% is set correctly.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5107 **Author:** [@dominik-ba](https://github.com/dominik-ba) **Created:** 3/24/2020 **Status:** ✅ Merged **Merged:** 3/24/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`99789ba`](https://github.com/microsoft/terminal/commit/99789baca4f0354d10bc0ce7f5c7d45dbe06c546) adding cmder icon to ThirdPartyToolProfiles - [`6844d26`](https://github.com/microsoft/terminal/commit/6844d26eb758c8b6040419d9cdde9d3abc693c51) Update doc/user-docs/ThirdPartyToolProfiles.md ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `doc/user-docs/ThirdPartyToolProfiles.md` (+1 -0) </details> ### 📄 Description ## Simply adding the icon property to the ThirdPartyToolProfiles examples md for cmder ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Detailed Description of the Pull Request / Additional comments I think not much detail needed since this only an update to a doc and not the main application. ## Validation Steps Performed I tried it locally and worked without any adjustments to the cmder folder. Just making sure (as already stated) the `%CMDER_ROOT%` is set correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:13:58 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26109