starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5129] [CLOSED] Spellchecking #26126

New Issue
Open
opened 2026-01-31 09:14:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:14:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5129
Author: @ghost
Created: 3/26/2020
Status: ❌ Closed

Base: master ← Head: Spelling

📝 Commits (6)

📊 Changes

40 files changed (+77 additions, -77 deletions)

View changed files

📝 build/pipelines/templates/check-formatting.yml (+1 -1)
📝 doc/specs/#2563 - closeOnExit and TerminalConnection evolution.md (+1 -1)
📝 doc/specs/#607 - Commandline Arguments for the Windows Terminal.md (+5 -5)
📝 doc/specs/#754 - Cascading Default Settings.md (+17 -17)
📝 doc/user-docs/UsingJsonSettings.md (+1 -1)
📝 src/buffer/out/OutputCellView.cpp (+1 -1)
📝 src/buffer/out/TextColor.cpp (+1 -1)
📝 src/cascadia/TerminalApp/AppCommandlineArgs.cpp (+1 -1)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+2 -2)
📝 src/cascadia/TerminalApp/DefaultProfileUtils.h (+1 -1)
📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+2 -2)
📝 src/cascadia/TerminalApp/PowershellCoreProfileGenerator.cpp (+10 -10)
📝 src/cascadia/TerminalApp/Tab.cpp (+1 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+1 -1)
📝 src/cascadia/TerminalCore/TerminalApi.cpp (+1 -1)
📝 src/cascadia/TerminalCore/TerminalDispatch.cpp (+1 -1)
📝 src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp (+1 -1)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+1 -1)
📝 src/host/consoleInformation.cpp (+2 -2)
📝 src/host/directio.cpp (+1 -1)

...and 20 more files

📄 Description

Summary of the Pull Request

Since we are now doing spellchecking, I thought I'd help out.

References

#4799

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed

Detailed Description of the Pull Request / Additional comments

Spell Checks

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5129 **Author:** [@ghost](https://github.com/ghost) **Created:** 3/26/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Spelling` --- ### 📝 Commits (6) - [`06ea16d`](https://github.com/microsoft/terminal/commit/06ea16ddb8142e68d4637684050509478a45e3da) Spellchecking - [`a5f8ae9`](https://github.com/microsoft/terminal/commit/a5f8ae9a256bc124b827437d9e8158ef674d49f2) Spelling p2 - [`b7a5e94`](https://github.com/microsoft/terminal/commit/b7a5e940ca66546666a1b2bdb0b35bc7673385ad) PowerShell - [`31ec0a1`](https://github.com/microsoft/terminal/commit/31ec0a1c60a04d2526abe56294a7c6e4e0e1352e) APIs - [`8c5da52`](https://github.com/microsoft/terminal/commit/8c5da5281d3b5942170621d280e7e2ee4f4268fa) last changes - [`c3e0e3b`](https://github.com/microsoft/terminal/commit/c3e0e3b39c48b27e02c411c0a925c2755079aa27) Update GlobalAppSettings.cpp ### 📊 Changes **40 files changed** (+77 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `build/pipelines/templates/check-formatting.yml` (+1 -1) 📝 `doc/specs/#2563 - closeOnExit and TerminalConnection evolution.md` (+1 -1) 📝 `doc/specs/#607 - Commandline Arguments for the Windows Terminal.md` (+5 -5) 📝 `doc/specs/#754 - Cascading Default Settings.md` (+17 -17) 📝 `doc/user-docs/UsingJsonSettings.md` (+1 -1) 📝 `src/buffer/out/OutputCellView.cpp` (+1 -1) 📝 `src/buffer/out/TextColor.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/AppCommandlineArgs.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+2 -2) 📝 `src/cascadia/TerminalApp/DefaultProfileUtils.h` (+1 -1) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+2 -2) 📝 `src/cascadia/TerminalApp/PowershellCoreProfileGenerator.cpp` (+10 -10) 📝 `src/cascadia/TerminalApp/Tab.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+1 -1) 📝 `src/cascadia/TerminalCore/TerminalApi.cpp` (+1 -1) 📝 `src/cascadia/TerminalCore/TerminalDispatch.cpp` (+1 -1) 📝 `src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp` (+1 -1) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+1 -1) 📝 `src/host/consoleInformation.cpp` (+2 -2) 📝 `src/host/directio.cpp` (+1 -1) _...and 20 more files_ </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Since we are now doing spellchecking, I thought I'd help out. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #4799 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [X] Tests added/passed <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Spell Checks <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26126
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?