[PR #5148] [MERGED] Make conechokey use ReadConsoleInputW by default #26136

Open
opened 2026-01-31 09:14:12 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5148
Author: @zadjii-msft
Created: 3/27/2020
Status: Merged
Merged: 3/30/2020
Merged by: @undefined

Base: masterHead: dev/migrie/f/conechokeyw


📝 Commits (1)

  • 3ddb563 Make conechokey use ReadConsoleInputW by default

📊 Changes

1 file changed (+120 additions, -6 deletions)

View changed files

📝 src/tools/echokey/main.cpp (+120 -6)

📄 Description

This PR updates our internal tool conechokey to use ReadConsoleInputW by default. It also adds a flag -a to force it to use ReadConsoleInputA.

I discovered this while digging around for #1503, but figured I'd get this checked in now while I'm still investigating.

Since this is just a helper tool, I spent as little effort writing this change - yea the whole tool could benefit from cleaner code but ain't nobody got time for that.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5148 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/27/2020 **Status:** ✅ Merged **Merged:** 3/30/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/f/conechokeyw` --- ### 📝 Commits (1) - [`3ddb563`](https://github.com/microsoft/terminal/commit/3ddb5632ba96b23f2fda74361e8518e87af8816f) Make conechokey use ReadConsoleInputW by default ### 📊 Changes **1 file changed** (+120 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/tools/echokey/main.cpp` (+120 -6) </details> ### 📄 Description This PR updates our internal tool `conechokey` to use `ReadConsoleInputW` by default. It also adds a flag `-a` to force it to use `ReadConsoleInputA`. I discovered this while digging around for #1503, but figured I'd get this checked in now while I'm still investigating. Since this is just a helper tool, I spent as little effort writing this change - yea the whole tool could benefit from cleaner code but _ain't nobody got time for that_. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:12 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26136