[PR #5148] Make conechokey use ReadConsoleInputW by default #26141

Open
opened 2026-01-31 09:14:13 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/5148

State: closed
Merged: Yes


This PR updates our internal tool conechokey to use ReadConsoleInputW by default. It also adds a flag -a to force it to use ReadConsoleInputA.

I discovered this while digging around for #1503, but figured I'd get this checked in now while I'm still investigating.

Since this is just a helper tool, I spent as little effort writing this change - yea the whole tool could benefit from cleaner code but ain't nobody got time for that.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/5148 **State:** closed **Merged:** Yes --- This PR updates our internal tool `conechokey` to use `ReadConsoleInputW` by default. It also adds a flag `-a` to force it to use `ReadConsoleInputA`. I discovered this while digging around for #1503, but figured I'd get this checked in now while I'm still investigating. Since this is just a helper tool, I spent as little effort writing this change - yea the whole tool could benefit from cleaner code but _ain't nobody got time for that_.
claunia added the pull-request label 2026-01-31 09:14:13 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26141