starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5150] [MERGED] add til::math, use it for float conversions to point, size #26146

New Issue
Open
opened 2026-01-31 09:14:15 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:14:15 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5150
Author: @DHowett-MSFT
Created: 3/27/2020
Status: ✅ Merged
Merged: 3/27/2020
Merged by: @undefined

Base: master ← Head: dev/duhowett/til_i_can_do_math

📝 Commits (2)

  • 138c6b9 add til::math and magic converters
  • dc1677c fix speeling, allowlist cxcy/isnan

📊 Changes

11 files changed (+490 additions, -0 deletions)

View changed files

📝 .github/actions/spell-check/dictionary/math.txt (+1 -0)
📝 .github/actions/spell-check/whitelist/whitelist.txt (+1 -0)
📝 src/inc/til.h (+1 -0)
➕ src/inc/til/math.h (+85 -0)
📝 src/inc/til/point.h (+16 -0)
📝 src/inc/til/size.h (+24 -0)
➕ src/til/ut_til/MathTests.cpp (+127 -0)
📝 src/til/ut_til/PointTests.cpp (+97 -0)
📝 src/til/ut_til/SizeTests.cpp (+136 -0)
📝 src/til/ut_til/sources (+1 -0)
📝 src/til/ut_til/til.unit.tests.vcxproj (+1 -0)

📄 Description

This pull request introduces the til::math namespace, which provides some casting functions to be used in support of til::point and til::size. When point/size want to ingest a floating-point structure, they must be instructed on how to convert those floating-point values into integers.

This enables:

Windows::Foundation::Point wfPoint = /* ... */;
til::point tp{ til::math::rounding, wfPoint };

Future thoughts: should the TilMath types be stackable? Right now, you cannot get "checked + rounding" behavior (where it throws if it doesn't fit) so everything is saturating.

PR Checklist

  • Closes a request by Michael
  • I've discussed this with core contributors already

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5150 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 3/27/2020 **Status:** ✅ Merged **Merged:** 3/27/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/duhowett/til_i_can_do_math` --- ### 📝 Commits (2) - [`138c6b9`](https://github.com/microsoft/terminal/commit/138c6b945a57fbbae167bd27bdfc78b091cbcdf9) add til::math and magic converters - [`dc1677c`](https://github.com/microsoft/terminal/commit/dc1677c4741531dd85a68ae7e22d6dc44cded853) fix speeling, allowlist cxcy/isnan ### 📊 Changes **11 files changed** (+490 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spell-check/dictionary/math.txt` (+1 -0) 📝 `.github/actions/spell-check/whitelist/whitelist.txt` (+1 -0) 📝 `src/inc/til.h` (+1 -0) ➕ `src/inc/til/math.h` (+85 -0) 📝 `src/inc/til/point.h` (+16 -0) 📝 `src/inc/til/size.h` (+24 -0) ➕ `src/til/ut_til/MathTests.cpp` (+127 -0) 📝 `src/til/ut_til/PointTests.cpp` (+97 -0) 📝 `src/til/ut_til/SizeTests.cpp` (+136 -0) 📝 `src/til/ut_til/sources` (+1 -0) 📝 `src/til/ut_til/til.unit.tests.vcxproj` (+1 -0) </details> ### 📄 Description This pull request introduces the `til::math` namespace, which provides some casting functions to be used in support of `til::point` and `til::size`. When point/size want to ingest a floating-point structure, they _must_ be instructed on how to convert those floating-point values into integers. This enables: ``` Windows::Foundation::Point wfPoint = /* ... */; til::point tp{ til::math::rounding, wfPoint }; ``` Future thoughts: should the TilMath types be stackable? Right now, you cannot get "checked + rounding" behavior (where it throws if it doesn't fit) so everything is saturating. ## PR Checklist * [x] Closes a request by Michael * [x] I've discussed this with core contributors already --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26146
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?