[PR #5194] [MERGED] Use an Automatic split for splitPane by default #26156

Open
opened 2026-01-31 09:14:19 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5194
Author: @zadjii-msft
Created: 3/31/2020
Status: Merged
Merged: 4/1/2020
Merged by: @undefined

Base: masterHead: dev/migrie/b/auto-split-by-default


📝 Commits (3)

  • 7999e86 Change the default split mode to automatic
  • fed2d53 fix the tests
  • 7205d94 Remove split as required from schema

📊 Changes

7 files changed (+230 additions, -223 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -1)
📝 doc/cascadia/profiles.schema.json (+1 -2)
📝 src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp (+3 -3)
📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+4 -4)
📝 src/cascadia/LocalTests_TerminalApp/TabTests.cpp (+217 -209)
📝 src/cascadia/TerminalApp/ActionArgs.h (+2 -2)
📝 src/cascadia/TerminalApp/AppCommandlineArgs.cpp (+2 -2)

📄 Description

Summary of the Pull Request

You no longer need to specify the split argument to splitPane, it will default to Automatic instead of None

PR Checklist

  • Closes a discussion we had in team sync
  • I work here
  • Tests updated
  • [n/a] Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments

Also disables the tests that are broken in #5169 while I investigate


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5194 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/31/2020 **Status:** ✅ Merged **Merged:** 4/1/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/auto-split-by-default` --- ### 📝 Commits (3) - [`7999e86`](https://github.com/microsoft/terminal/commit/7999e8675b5ed66c0c475c5206f9d9815a02ae3b) Change the default split mode to automatic - [`fed2d53`](https://github.com/microsoft/terminal/commit/fed2d5342d72903f3bb231b37c7904a0eadb3ccf) fix the tests - [`7205d94`](https://github.com/microsoft/terminal/commit/7205d94e2de42e6ef0ca26c3c3d61eb86752673e) Remove split as required from schema ### 📊 Changes **7 files changed** (+230 additions, -223 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -1) 📝 `doc/cascadia/profiles.schema.json` (+1 -2) 📝 `src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp` (+3 -3) 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+4 -4) 📝 `src/cascadia/LocalTests_TerminalApp/TabTests.cpp` (+217 -209) 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+2 -2) 📝 `src/cascadia/TerminalApp/AppCommandlineArgs.cpp` (+2 -2) </details> ### 📄 Description ## Summary of the Pull Request You no longer _need_ to specify the `split` argument to `splitPane`, it will default to `Automatic` instead of `None` ## PR Checklist * [x] Closes a discussion we had in team sync * [x] I work here * [x] Tests updated * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments Also disables the tests that are broken in #5169 while I investigate --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:19 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26156