[PR #5190] [MERGED] Remove a heap of legacy settings deserialization #26157

Open
opened 2026-01-31 09:14:19 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5190
Author: @DHowett-MSFT
Created: 3/31/2020
Status: Merged
Merged: 3/31/2020
Merged by: @DHowett-MSFT

Base: masterHead: dev/duhowett/legacy;_it_lives_on


📝 Commits (5)

  • bba1d65 Settings: Remove support for /globals
  • 4a25554 Settings: remove legacy colorscheme key and colorTable
  • deef5e4 Settings: remove support for colorScheme.colors (array)
  • 735c1f6 Settings: delete all legacy keybinding deserializers
  • 14bd5c1 Update the docs for the deleted settings

📊 Changes

15 files changed (+61 additions, -632 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -2)
📝 doc/cascadia/profiles.schema.json (+19 -30)
📝 doc/user-docs/UsingJsonSettings.md (+1 -1)
📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+8 -68)
📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+13 -137)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+4 -234)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+1 -1)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+0 -17)
📝 src/cascadia/TerminalApp/ColorScheme.cpp (+0 -17)
📝 src/cascadia/TerminalApp/Profile.cpp (+0 -37)
📝 src/cascadia/TerminalApp/Profile.h (+0 -1)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.cpp (+1 -37)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.idl (+1 -29)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+10 -19)
📝 src/cascadia/TerminalApp/defaults.json (+2 -2)

📄 Description

This pull request removes support for:

  • legacy keybindings of all types
  • colorScheme.colors, as an array
  • A globals object in the root of the settings file
  • profile.colorTable and profile.colorscheme (the rare v0.1 all-lowercase variety)

c637a6757fe33edd78123a549c41405c0e77ac3a - Settings: delete all legacy keybinding deserializers

fc0d22e7fb62b5c30664c5513c07025a830dacad - Settings: remove support for colorScheme.colors (array)

e3bc5a9afd255e478928512365cd80796c983381 - Settings: remove legacy colorscheme key and colorTable

bba1d651f3 - Settings: Remove support for /globals

Fixes #4091.
Fixes #1069.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5190 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 3/31/2020 **Status:** ✅ Merged **Merged:** 3/31/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/legacy;_it_lives_on` --- ### 📝 Commits (5) - [`bba1d65`](https://github.com/microsoft/terminal/commit/bba1d651f3d532f8d46be6e29c72a6097cab60b4) Settings: Remove support for /globals - [`4a25554`](https://github.com/microsoft/terminal/commit/4a255541dc63cde978285afcae450d4c95a2deda) Settings: remove legacy colorscheme key and colorTable - [`deef5e4`](https://github.com/microsoft/terminal/commit/deef5e46e62c0e1fe05899bebf407bcc3c8b3f78) Settings: remove support for colorScheme.colors (array) - [`735c1f6`](https://github.com/microsoft/terminal/commit/735c1f676b1e8cdaf566c8c02602900bece65664) Settings: delete all legacy keybinding deserializers - [`14bd5c1`](https://github.com/microsoft/terminal/commit/14bd5c16cc9dc83d9554fa67571c90152abfdb99) Update the docs for the deleted settings ### 📊 Changes **15 files changed** (+61 additions, -632 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -2) 📝 `doc/cascadia/profiles.schema.json` (+19 -30) 📝 `doc/user-docs/UsingJsonSettings.md` (+1 -1) 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+8 -68) 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+13 -137) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+4 -234) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+0 -17) 📝 `src/cascadia/TerminalApp/ColorScheme.cpp` (+0 -17) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+0 -37) 📝 `src/cascadia/TerminalApp/Profile.h` (+0 -1) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.cpp` (+1 -37) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.idl` (+1 -29) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+10 -19) 📝 `src/cascadia/TerminalApp/defaults.json` (+2 -2) </details> ### 📄 Description This pull request removes support for: * legacy keybindings of all types * `colorScheme.colors`, as an array * A `globals` object in the root of the settings file * `profile.colorTable` and `profile.colorscheme` (the rare v0.1 all-lowercase variety) ### c637a6757fe33edd78123a549c41405c0e77ac3a - Settings: delete all legacy keybinding deserializers ### fc0d22e7fb62b5c30664c5513c07025a830dacad - Settings: remove support for colorScheme.colors (array) ### e3bc5a9afd255e478928512365cd80796c983381 - Settings: remove legacy colorscheme key and colorTable ### bba1d651f3d532f8d46be6e29c72a6097cab60b4 - Settings: Remove support for /globals Fixes #4091. Fixes #1069. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:19 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26157