[PR #5211] ci: spelling: update and include advice #26181

Open
opened 2026-01-31 09:14:28 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/5211

State: closed
Merged: Yes


Summary of the Pull Request

This updates the spell checker.
Scheduled checks should now function, this means that if someone has a fork and isn't allowing actions to run in their fork, this repository should be able to run a spell check against the PR similar to the way checks would be run otherwise.

References

This is designed to be merged after #5207

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: https://github.com/microsoft/terminal/pull/4799#issuecomment-604121242

Detailed Description of the Pull Request / Additional comments

Note: due to a bug in a previous version, i'th was treated as an acceptable term. This update fixes that bug which makes the checking stricter. nth is in the dictionary, and thus I've used it instead.

You can see how advice works because I'm conveniently building on top of an unhappy commit. If @DHowett-MSFT / @miniksa / @zadjii-msft have input about how the advice should be worded, we can certainly adjust that here (or you're welcome to tune it later).

Validation Steps Performed

I pushed this commit (and a couple of variants) to my fork. That resulted in f2d57bcc3c (the ❌).

**Original Pull Request:** https://github.com/microsoft/terminal/pull/5211 **State:** closed **Merged:** Yes --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This updates the spell checker. Scheduled checks should now function, this means that if someone has a fork and isn't allowing actions to run in their fork, this repository should be able to run a spell check against the PR similar to the way checks would be run otherwise. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References This is designed to be merged after #5207 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: https://github.com/microsoft/terminal/pull/4799#issuecomment-604121242 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Note: due to a bug in a previous version, `i'th` was treated as an acceptable term. This update fixes that bug which makes the checking stricter. `nth` is in the dictionary, and thus I've used it instead. You can see how advice works because I'm conveniently building on top of an unhappy commit. If @DHowett-MSFT / @miniksa / @zadjii-msft have input about how the advice should be worded, we can certainly adjust that here (or you're welcome to tune it later). <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed I pushed this commit (and a couple of variants) to my fork. That resulted in https://github.com/jsoref/terminal/commit/f2d57bcc3cac00252afea203f958971c6d3b4b58 (the ❌).
claunia added the pull-request label 2026-01-31 09:14:28 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26181