starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5231] [MERGED] Add default values to defaults.json #26197

New Issue
Open
opened 2026-01-31 09:14:34 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:14:34 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5231
Author: @carlos-zamora
Created: 4/3/2020
Status: ✅ Merged
Merged: 4/10/2020
Merged by: @undefined

Base: master ← Head: dev/cazamor/settings-defaults

📝 Commits (10+)

  • c34c43f fix json
  • 6dc7916 fix typo in defaults.json and update theme
  • 8a56ac0 [CODE] allow defaults.json to have profiles.defaults
  • 3653ab3 add nullable profile settings + update keybindings
  • 8bf734b add comment about 'closeTab' and fix minor spacing issue
  • 8914042 remove code changes
  • e59110b reword comment
  • d91a41c undo changing profiles into an object
  • de9461c address Dustin's comments. Try something new with profiles
  • eb8b879 remove comment. Keep order of 'unique' then 'same/alphabetical'

📊 Changes

5 files changed (+72 additions, -39 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+2 -3)
📝 doc/cascadia/profiles.schema.json (+5 -5)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+2 -1)
📝 src/cascadia/TerminalApp/defaults-universal.json (+25 -9)
📝 src/cascadia/TerminalApp/defaults.json (+38 -21)

📄 Description

Summary of the Pull Request

This updates defaults.json to include the default values for all global and profile settings. Most default keybinding args are added too. This also updates a few outdated items found in the docs.

PR Checklist

Validation Steps Performed

After making the changes, I made sure all of the settings are deserialized by debugging and stepping through the LayerJson code.

  • Global Settings

I was mainly looking for two things:

  • the key/value pair is found and read
  • the value did not change before/after the pair was read

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5231 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 4/3/2020 **Status:** ✅ Merged **Merged:** 4/10/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/settings-defaults` --- ### 📝 Commits (10+) - [`c34c43f`](https://github.com/microsoft/terminal/commit/c34c43f7a31f82fc7c650f30fa6ab90318b0e532) fix json - [`6dc7916`](https://github.com/microsoft/terminal/commit/6dc791631538e57c2d56055f1882ecb17be7d376) fix typo in defaults.json and update theme - [`8a56ac0`](https://github.com/microsoft/terminal/commit/8a56ac023b6a6d557954cdf4fc22333626723af0) [CODE] allow defaults.json to have profiles.defaults - [`3653ab3`](https://github.com/microsoft/terminal/commit/3653ab3d2cbee8aa9b16af0ead1cd6b23fbe54da) add nullable profile settings + update keybindings - [`8bf734b`](https://github.com/microsoft/terminal/commit/8bf734b43ce0be7a36dda4b90abe522567571b7d) add comment about 'closeTab' and fix minor spacing issue - [`8914042`](https://github.com/microsoft/terminal/commit/891404290e551b62cccd0d3c125ab3c0344cad06) remove code changes - [`e59110b`](https://github.com/microsoft/terminal/commit/e59110b4191465d029df68974f393ad49099645c) reword comment - [`d91a41c`](https://github.com/microsoft/terminal/commit/d91a41ce9eb7ca0efc06a1391386605eb30ce478) undo changing profiles into an object - [`de9461c`](https://github.com/microsoft/terminal/commit/de9461ce08ff307aa46f724d2d9c833dd8368f21) address Dustin's comments. Try something new with profiles - [`eb8b879`](https://github.com/microsoft/terminal/commit/eb8b87990a9c68cd764b95b704b3f35be0664429) remove comment. Keep order of 'unique' then 'same/alphabetical' ### 📊 Changes **5 files changed** (+72 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+2 -3) 📝 `doc/cascadia/profiles.schema.json` (+5 -5) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+2 -1) 📝 `src/cascadia/TerminalApp/defaults-universal.json` (+25 -9) 📝 `src/cascadia/TerminalApp/defaults.json` (+38 -21) </details> ### 📄 Description ## Summary of the Pull Request This updates defaults.json to include the default values for all global and profile settings. Most default keybinding args are added too. This also updates a few outdated items found in the docs. ## PR Checklist * [X] Closes #5189 ## Validation Steps Performed After making the changes, I made sure all of the settings are deserialized by debugging and stepping through the `LayerJson` code. - [X] Global Settings I was mainly looking for two things: - the key/value pair is found and read - the value did not change before/after the pair was read --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26197
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?