starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Sanitize paths when pasting into a bash shell #2620

New Issue
Closed
opened 2026-01-30 22:59:54 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:59:54 +00:00
Owner
Copy Link

Originally created by @axfelix on GitHub (Jul 7, 2019).

Summary of the new feature/enhancement

Not sure if this is out of scope, but it would be nice if Windows Terminal could automatically sanitize paths (e.g. quoting spaces, inverting or escaping Windows-style slashes) when pasting to a non-cmd, non-Powershell environment. ConEmu's Far Manager does this and it makes mingw bash much more usable.

Proposed technical implementation details (optional)

Automatically make assumptions about the running shell and change pasted paths to match the interpreter flavour.

P.S.: Just noticed you already fixed the Windows Terminal gsyncing my entire desktop when it's focused, thanks! If you add this feature and a warning on quitting when you have an ssh connection open or another running program, I'll be really happy to switch to using Windows Terminal fulltime!

Originally created by @axfelix on GitHub (Jul 7, 2019). # Summary of the new feature/enhancement Not sure if this is out of scope, but it would be nice if Windows Terminal could automatically sanitize paths (e.g. quoting spaces, inverting or escaping Windows-style slashes) when pasting to a non-cmd, non-Powershell environment. ConEmu's Far Manager does this and it makes mingw bash much more usable. # Proposed technical implementation details (optional) Automatically make assumptions about the running shell and change pasted paths to match the interpreter flavour. P.S.: Just noticed you already fixed the Windows Terminal gsyncing my entire desktop when it's focused, thanks! If you add this feature and a warning on quitting when you have an ssh connection open or another running program, I'll be really happy to switch to using Windows Terminal fulltime!
claunia added the Issue-FeatureResolution-Duplicate labels 2026-01-30 22:59:54 +00:00
claunia commented 2026-01-30 22:59:55 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 7, 2019):

This'll also be related to #904 and #331; there's a bunch of pain in "detecting" on both sides of this problem.

The first is pain in detecting what is a path; for example, /Windows is a valid path to powershell on Windows, but it looks like an absolute WSL path. Blindly taking things off the clipboard and trying to access-check them is a recipe for a bad time, too, because that'll almost certainly bother more than one antivirus solution. Blindly taking things off the clipboard and trying to access-check them as WSL paths (for conversion back to Windows) is even more a recipe for a bad time, for the aforementioned^ and because WT cannot access check within your WSL distributions.

The second is detecting what the shell is on the other end of the terminal. For local shells it's possible, although easily fooled (wsl -> powershell.exe -> cmd.exe should be detected as cmd but the terminal only knows about wsl), and for remote shells it is impossible in the general case. 😄

@DHowett-MSFT commented on GitHub (Jul 7, 2019): This'll also be related to #904 and #331; there's a bunch of pain in "detecting" on both sides of this problem. The first is pain in detecting _what is a path_; for example, `/Windows` is a valid path to powershell on Windows, but it looks like an absolute WSL path. Blindly taking things off the clipboard and trying to access-check them is a recipe for a bad time, too, because that'll almost certainly bother more than one antivirus solution. Blindly taking things off the clipboard and trying to access-check them _as WSL paths_ (for conversion back to Windows) is even more a recipe for a bad time, for the aforementioned^ and because WT cannot access check within your WSL distributions. The second is detecting what the shell is on the other end of the terminal. For local shells it's possible, although easily fooled (wsl -> powershell.exe -> cmd.exe should be detected as cmd but the terminal only knows about wsl), and for remote shells it is impossible in the general case. :smile:
claunia commented 2026-01-30 22:59:55 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 8, 2019):

Also, this is #1772 😄

@DHowett-MSFT commented on GitHub (Jul 8, 2019): Also, this is #1772 :smile:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2620
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?