starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5265] [MERGED] Rename 'requestedTheme' to 'theme' #26209

New Issue
Open
opened 2026-01-31 09:14:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:14:38 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5265
Author: @carlos-zamora
Created: 4/7/2020
Status: ✅ Merged
Merged: 4/7/2020
Merged by: @undefined

Base: master ← Head: dev/cazamor/settings/theme

📝 Commits (2)

  • 6f5f334 rename 'requestedTheme' to 'theme'
  • 9eb36cb forgot about universal defaults

📊 Changes

7 files changed (+21 additions, -23 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -1)
📝 doc/cascadia/profiles.schema.json (+1 -1)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+4 -4)
📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+9 -9)
📝 src/cascadia/TerminalApp/GlobalAppSettings.h (+4 -6)
📝 src/cascadia/TerminalApp/defaults-universal.json (+1 -1)
📝 src/cascadia/TerminalApp/defaults.json (+1 -1)

📄 Description

Summary of the Pull Request

Renames the requestedTheme global setting to theme. Propagates updates to...

  • schema
  • doc
  • defaults.json
  • universal-defaults.json

PR Checklist

Validation Steps Performed

theme Success?
system ✔
light ✔
dark ✔

But we really know that dark is the one we care about here 😉

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5265 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 4/7/2020 **Status:** ✅ Merged **Merged:** 4/7/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/settings/theme` --- ### 📝 Commits (2) - [`6f5f334`](https://github.com/microsoft/terminal/commit/6f5f334a5cac9f8e9fe8ea042eb03002feda45fe) rename 'requestedTheme' to 'theme' - [`9eb36cb`](https://github.com/microsoft/terminal/commit/9eb36cbec2c82d408e30a823985920f61646f604) forgot about universal defaults ### 📊 Changes **7 files changed** (+21 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -1) 📝 `doc/cascadia/profiles.schema.json` (+1 -1) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+4 -4) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+9 -9) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.h` (+4 -6) 📝 `src/cascadia/TerminalApp/defaults-universal.json` (+1 -1) 📝 `src/cascadia/TerminalApp/defaults.json` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request Renames the `requestedTheme` global setting to `theme`. Propagates updates to... - schema - doc - defaults.json - universal-defaults.json ## PR Checklist * [X] Closes #5264 ## Validation Steps Performed | `theme` | Success? | |--|--| | `system` | ✔ | | `light` | ✔ | | `dark` | ✔ | But we really know that `dark` is the one we care about here 😉 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26209
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?