starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5274] [MERGED] Fall back to TerminalApp.dll's version when we're unpackaged #26216

New Issue
Open
opened 2026-01-31 09:14:42 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:14:42 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5274
Author: @DHowett-MSFT
Created: 4/7/2020
Status: ✅ Merged
Merged: 4/9/2020
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/aboutbox_extra_credit

📝 Commits (6)

  • 824c760 About dialog: calculate the file version in unpackaged scenarios
  • d867906 Use the localized version instead
  • 43ca1a4 Did you guess I had not compiled the latest change?
  • 29e75c4 Did you guess I had not compiled the latest change II?
  • 8c61207 LCID is a thing.
  • f038cd6 Merge remote-tracking branch 'origin/master' into dev/duhowett/aboutbox_extra_credit

📊 Changes

2 files changed (+34 additions, -0 deletions)

View changed files

📝 .github/actions/spell-check/dictionary/apis.txt (+1 -0)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+33 -0)

📄 Description

Summary of the Pull Request

This pull request makes sure we still get a usable (for troubleshooting purposes) version number in the about dialog and settings file when the user is running unpackaged.

image

image

I've had this laying around since I reworked the about dialog.

PR Checklist

  • Closes nothing.
  • work here
  • Tests added/passed
  • Requires documentation to be updated
  • work here!

Detailed Description of the Pull Request / Additional comments

The code looks hairy, and we could pull it out into a helper. It's straightforward except for the magic LCID constant.

The story behind that constant: by default, Package ES emits version resource information that says we're localized to ... language zero.
It also emits a language-coded version block for 0x0409 (en-US).

These two things cannot both be true.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5274 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 4/7/2020 **Status:** ✅ Merged **Merged:** 4/9/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/aboutbox_extra_credit` --- ### 📝 Commits (6) - [`824c760`](https://github.com/microsoft/terminal/commit/824c76054e647bdcef4b4d830ceab2cd7133b1bc) About dialog: calculate the file version in unpackaged scenarios - [`d867906`](https://github.com/microsoft/terminal/commit/d867906b84cb9daa93fcba738dddade588e4f7da) Use the localized version instead - [`43ca1a4`](https://github.com/microsoft/terminal/commit/43ca1a46329e8b06d808f9ee234a982cfea92521) Did you guess I had not compiled the latest change? - [`29e75c4`](https://github.com/microsoft/terminal/commit/29e75c4d0de0b8a3e945b00899e258b2a8906f84) Did you guess I had not compiled the latest change II? - [`8c61207`](https://github.com/microsoft/terminal/commit/8c61207b716ff2b79dd8308e4937c2d59e034e7d) LCID is a thing. - [`f038cd6`](https://github.com/microsoft/terminal/commit/f038cd63508421a7359b35076c2289b7175f3b4e) Merge remote-tracking branch 'origin/master' into dev/duhowett/aboutbox_extra_credit ### 📊 Changes **2 files changed** (+34 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spell-check/dictionary/apis.txt` (+1 -0) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+33 -0) </details> ### 📄 Description ## Summary of the Pull Request This pull request makes sure we still get a usable (for troubleshooting purposes) version number in the about dialog and settings file when the user is running unpackaged. ![image](https://user-images.githubusercontent.com/14316954/78717232-29a0e980-78d5-11ea-9555-4df6c5c1656f.png) ![image](https://user-images.githubusercontent.com/14316954/78717279-3b828c80-78d5-11ea-9238-a69d25e5be8d.png) I've had this laying around since I reworked the about dialog. ## PR Checklist * [ ] Closes nothing. * [x] work here * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] work here! ## Detailed Description of the Pull Request / Additional comments The code looks hairy, and we could pull it out into a helper. It's straightforward except for the magic LCID constant. The story behind that constant: by default, Package ES emits version resource information that says we're localized to ... language zero. It also emits a language-coded version block for 0x0409 (en-US). These two things cannot both be true. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?