[PR #5287] [MERGED] Localize the profile name for cmd, change it to Command Prompt #26229

Open
opened 2026-01-31 09:14:48 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5287
Author: @DHowett-MSFT
Created: 4/8/2020
Status: ✅ Merged
Merged: 4/8/2020
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/localize_cmd


📝 Commits (1)

  • a2622e6 Localize the profile name for cmd, change it to Command Prompt

📊 Changes

4 files changed (+9 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+3 -0)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+4 -0)
📝 src/cascadia/TerminalApp/defaults.json (+1 -1)
📝 src/cascadia/TerminalApp/userDefaults.json (+1 -1)

📄 Description

This commit introduces another template replacement for the user's
default settings, COMMAND_PROMPT_LOCALIZED_NAME, which will be replaced
with the contents of the CommandPromptDisplayName resource.

By default, that will be "Command Prompt." This name change will apply
only for new users, and only on first launch. Changes in the system
locale after first launch will not impact the name of the profile.

If the user removes the name from their command prompt profile, its
name will revert irrecoverably to "Command Prompt". They will not be
given a chance to regenerate a localized name.

Fixes #4476.

References

Possibly rejected proposal for dynamic localized json strings: #5280

PR Checklist

Validation

Deleted my profiles.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5287 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 4/8/2020 **Status:** ✅ Merged **Merged:** 4/8/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/localize_cmd` --- ### 📝 Commits (1) - [`a2622e6`](https://github.com/microsoft/terminal/commit/a2622e6fdcbbc3d02212bba6972fc78a608eb122) Localize the profile name for cmd, change it to Command Prompt ### 📊 Changes **4 files changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+3 -0) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+4 -0) 📝 `src/cascadia/TerminalApp/defaults.json` (+1 -1) 📝 `src/cascadia/TerminalApp/userDefaults.json` (+1 -1) </details> ### 📄 Description This commit introduces another template replacement for the user's default settings, COMMAND_PROMPT_LOCALIZED_NAME, which will be replaced with the contents of the CommandPromptDisplayName resource. By default, that will be "Command Prompt." This name change will apply only for new users, and only on first launch. Changes in the system locale after first launch will not impact the name of the profile. If the user _removes_ the name from their command prompt profile, its name will revert irrecoverably to "Command Prompt". They will not be given a chance to regenerate a localized name. Fixes #4476. ## References Possibly rejected proposal for dynamic localized json strings: #5280 ## PR Checklist * [x] Closes #4476 * [x] CLA signed * [ ] Tests added/passed * [x] Requires documentation to be updated * [x] I've discussed this with core contributors already. ## Validation Deleted my profiles. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:48 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26229