starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5304] [MERGED] doc: clean up the schema #26247

New Issue
Open
opened 2026-01-31 09:14:54 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:14:54 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5304
Author: @carlos-zamora
Created: 4/9/2020
Status: ✅ Merged
Merged: 4/28/2020
Merged by: @DHowett-MSFT

Base: master ← Head: dev/cazamor/schema/nullable-colors

📝 Commits (8)

📊 Changes

1 file changed (+39 additions, -116 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+39 -116)

📄 Description

Summary of the Pull Request

This PR performs a number of miscellaneous clean-up tasks on our schema:

  • allow null for some settings
  • update some default values to be more useful
  • consistently use " instead of '
  • remove colorTable
  • provide missing description for backgroundImageOpacity
  • update cursorShape to have options match order displayed in vs code
  • if a setting has multiple options, provide a list of those options with a short description on each
    • this one I only did a few times
  • remove a little bit of ambiguity on some descriptions

PR Checklist

Closes #5279

Detailed Description of the Pull Request / Additional comments

Validation was performed for...

  • Global Settings
  • Profile Settings
  • Keybinding Actions

Validation Steps Performed

I linked VS Code to the my version of the schema. Defined all settings from scratch in settings.json. Anytime I found something off, I updated the schema and saw if it looks right.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5304 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 4/9/2020 **Status:** ✅ Merged **Merged:** 4/28/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/cazamor/schema/nullable-colors` --- ### 📝 Commits (8) - [`708de5e`](https://github.com/microsoft/terminal/commit/708de5e0f69846c438087accdf5d5f14018de412) draft: clean up schema - [`94db358`](https://github.com/microsoft/terminal/commit/94db358948deb45c65da21b13859829feedf3f5b) address a few of Dustin's comments - [`db517d8`](https://github.com/microsoft/terminal/commit/db517d87522038de4c6ace99325b08bd10e38912) added a few more fixes from Dustin - [`de49a6e`](https://github.com/microsoft/terminal/commit/de49a6e7f2452572ae09c3b0b2712449b001347a) tweak keybinding schema - [`84ebd21`](https://github.com/microsoft/terminal/commit/84ebd21ff5adf7bbc25595d0e53d1a1a9a37fd95) a few PR changes - [`0217cad`](https://github.com/microsoft/terminal/commit/0217cadf0e03106fe374209e8c39d9066ca6ef7b) remove connectionType - [`00b233a`](https://github.com/microsoft/terminal/commit/00b233ad501afbb20f81bfc4297d300f86ea6eed) let's ship this - [`5aec1b9`](https://github.com/microsoft/terminal/commit/5aec1b93945920c1f2ad00503bc0741a20bf09c6) merge master ### 📊 Changes **1 file changed** (+39 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+39 -116) </details> ### 📄 Description ## Summary of the Pull Request This PR performs a number of miscellaneous clean-up tasks on our schema: - [X] allow null for some settings - [X] update some default values to be more useful - [X] consistently use " instead of ' - [X] remove colorTable - [X] provide missing description for `backgroundImageOpacity` - [X] update cursorShape to have options match order displayed in vs code - [X] if a setting has multiple options, provide a list of those options with a short description on each - this one I only did a few times - [X] remove a little bit of ambiguity on some descriptions ## PR Checklist Closes #5279 ## Detailed Description of the Pull Request / Additional comments Validation was performed for... - [X] Global Settings - [X] Profile Settings - [x] Keybinding Actions ## Validation Steps Performed I linked VS Code to the my version of the schema. Defined all settings from scratch in settings.json. Anytime I found something off, I updated the schema and saw if it looks right. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26247
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?