[PR #5339] [MERGED] Fix localizability issues in Windows Terminal #26255

Open
opened 2026-01-31 09:14:58 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5339
Author: @DHowett-MSFT
Created: 4/13/2020
Status: ✅ Merged
Merged: 4/14/2020
Merged by: @undefined

Base: master ← Head: dev/duhowett/fix_loc_issues


📝 Commits (4)

  • 2f4e976 Fix localizability issues in Windows Terminal
  • 66725aa Clarify comments.
  • b80839b Lock the resources more fine-grainedlike
  • a5521dc Merge remote-tracking branch 'origin/master' into dev/duhowett/fix_loc_issues

📊 Changes

6 files changed (+54 additions, -46 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppLogic.cpp (+4 -0)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+22 -26)
📝 src/cascadia/TerminalConnection/AzureConnection.cpp (+3 -3)
📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+2 -2)
📝 src/cascadia/TerminalConnection/Resources/en-US/Resources.resw (+22 -15)
📝 src/cascadia/TerminalControl/Resources/en-US/Resources.resw (+1 -0)

📄 Description

Loc issues are given to us through the internal bug tracker.

  • Lock some strings, or parts of strings, that should not be localized.
  • Switch to positional format parameters
  • Remove the forced newlines in the warning resources; insert them at
    runtime

Fixes MSFT:25936156.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5339 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 4/13/2020 **Status:** ✅ Merged **Merged:** 4/14/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/duhowett/fix_loc_issues` --- ### 📝 Commits (4) - [`2f4e976`](https://github.com/microsoft/terminal/commit/2f4e976c8f440c75f69bfd55ffe0ac32121a88b4) Fix localizability issues in Windows Terminal - [`66725aa`](https://github.com/microsoft/terminal/commit/66725aa39ab5213d6b7e83d7834620b1ac5d416f) Clarify comments. - [`b80839b`](https://github.com/microsoft/terminal/commit/b80839b7b0e3f58c573dd27b45a31fec5818d98b) Lock the resources more fine-grainedlike - [`a5521dc`](https://github.com/microsoft/terminal/commit/a5521dca413ba9afb0cab500ce8578cbfd50ef07) Merge remote-tracking branch 'origin/master' into dev/duhowett/fix_loc_issues ### 📊 Changes **6 files changed** (+54 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+4 -0) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+22 -26) 📝 `src/cascadia/TerminalConnection/AzureConnection.cpp` (+3 -3) 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+2 -2) 📝 `src/cascadia/TerminalConnection/Resources/en-US/Resources.resw` (+22 -15) 📝 `src/cascadia/TerminalControl/Resources/en-US/Resources.resw` (+1 -0) </details> ### 📄 Description Loc issues are given to us through the internal bug tracker. * Lock some strings, or parts of strings, that should not be localized. * Switch to positional format parameters * Remove the forced newlines in the warning resources; insert them at runtime Fixes MSFT:25936156. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:14:58 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26255