[PR #5364] [CLOSED] Cinnamon/settings ui #26275

Open
opened 2026-01-31 09:15:06 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5364
Author: @Chips1234
Created: 4/15/2020
Status: Closed

Base: masterHead: cinnamon/settings-ui


📝 Commits (4)

  • 6a0d3a8 basic XAML pages with navigation
  • c184b1a code cleanup
  • 6632697 merge master (and fix)
  • bbf7027 Added ptr to actual settings in SettingsPage

📊 Changes

27 files changed (+1262 additions, -4 deletions)

View changed files

src/cascadia/TerminalApp/SettingsPage.cpp (+93 -0)
src/cascadia/TerminalApp/SettingsPage.h (+41 -0)
src/cascadia/TerminalApp/SettingsPage.idl (+10 -0)
src/cascadia/TerminalApp/SettingsPage.xaml (+46 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+3 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+3 -0)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+4 -3)
src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.cpp (+30 -0)
src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.h (+23 -0)
src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.idl (+9 -0)
src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.xaml (+478 -0)
src/cascadia/TerminalApp/lib/GlobalSettingsContent.cpp (+36 -0)
src/cascadia/TerminalApp/lib/GlobalSettingsContent.h (+24 -0)
src/cascadia/TerminalApp/lib/GlobalSettingsContent.idl (+9 -0)
src/cascadia/TerminalApp/lib/GlobalSettingsContent.xaml (+50 -0)
src/cascadia/TerminalApp/lib/GlobalsSettingsContent.cpp (+27 -0)
src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.cpp (+34 -0)
src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.h (+27 -0)
src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.idl (+9 -0)
src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.xaml (+25 -0)

...and 7 more files

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5364 **Author:** [@Chips1234](https://github.com/Chips1234) **Created:** 4/15/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cinnamon/settings-ui` --- ### 📝 Commits (4) - [`6a0d3a8`](https://github.com/microsoft/terminal/commit/6a0d3a8bb2355f72840f292d0970732c45d30732) basic XAML pages with navigation - [`c184b1a`](https://github.com/microsoft/terminal/commit/c184b1a35988cbeabb4781a0e0be734ab18f7c7c) code cleanup - [`6632697`](https://github.com/microsoft/terminal/commit/66326971987aa60f11cbc0cbf528069f32e31bc6) merge master (and fix) - [`bbf7027`](https://github.com/microsoft/terminal/commit/bbf70275866a4884ddf9a1765583beb6096f6cb6) Added ptr to actual settings in SettingsPage ### 📊 Changes **27 files changed** (+1262 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `src/cascadia/TerminalApp/SettingsPage.cpp` (+93 -0) ➕ `src/cascadia/TerminalApp/SettingsPage.h` (+41 -0) ➕ `src/cascadia/TerminalApp/SettingsPage.idl` (+10 -0) ➕ `src/cascadia/TerminalApp/SettingsPage.xaml` (+46 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+3 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+3 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+4 -3) ➕ `src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.cpp` (+30 -0) ➕ `src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.h` (+23 -0) ➕ `src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.idl` (+9 -0) ➕ `src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.xaml` (+478 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalSettingsContent.cpp` (+36 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalSettingsContent.h` (+24 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalSettingsContent.idl` (+9 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalSettingsContent.xaml` (+50 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalsSettingsContent.cpp` (+27 -0) ➕ `src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.cpp` (+34 -0) ➕ `src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.h` (+27 -0) ➕ `src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.idl` (+9 -0) ➕ `src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.xaml` (+25 -0) _...and 7 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:06 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26275