starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5368] Don't reflow a line as wrapped if it broke on the last cell #26284

New Issue
Closed
opened 2026-01-31 09:15:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:15:08 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/5368

State: closed
Merged: No

Summary of the Pull Request

If we write a character to the last cell of a row, we'll mark that row as wrapped.

If we linefeed at that point, we'll unmark that row as wrapped. (Linefeeds are important here, we learned in #5291/#5294 that all cursor movements don't actually break a line).

However, in TextBuffer::Reflow, if we increase the width of that row, we'll actually reflow it and the following row as though the first row wrapped. This is due to a iRight < cOldColsTotal that should have been iRight <= cOldColsTotal.

References

  • See #5291/#5294 for where we learned about cursor movements and line wrapping.

PR Checklist

Validation Steps Performed

Tested with the following command in WSL

printf "%*s\\n" "$(tput cols)" "" | tr " " "X"
  • In conhost, this works like a charm
  • This DOESN'T work in the Terminal. Presumably, the last cell getting written like this causes us to print the 'X' line as wrapped, but we never re-render that character as not wrapped when the line breaks. This seems timing related. I've got a test ready, but I want to make sure the test gets all possible cases here, including WriteCharsLegacy ones

I'm drafting this to get feedback on the < to <= fix so far. I'll work on the conpty fix in the meantime

**Original Pull Request:** https://github.com/microsoft/terminal/pull/5368 **State:** closed **Merged:** No --- ## Summary of the Pull Request If we write a character to the last cell of a row, we'll mark that row as wrapped. If we linefeed at that point, we'll unmark that row as wrapped. (Linefeeds are important here, we learned in #5291/#5294 that all cursor movements don't actually break a line). However, in `TextBuffer::Reflow`, if we increase the width of that row, we'll actually reflow it and the following row as though the first row wrapped. This is due to a `iRight < cOldColsTotal` that should have been `iRight <= cOldColsTotal`. ## References * See #5291/#5294 for where we learned about cursor movements and line wrapping. ## PR Checklist * [x] Closes #3088 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Tested with the following command in WSL ```sh printf "%*s\\n" "$(tput cols)" "" | tr " " "X" ``` * [x] In conhost, this works like a charm * [ ] This **DOESN'T** work in the Terminal. Presumably, the last cell getting written like this causes us to print the 'X' line as wrapped, but we never re-render that character as _not_ wrapped when the line breaks. This seems timing related. I've got a test ready, but I want to make sure the test gets all possible cases here, _including_ `WriteCharsLegacy` ones I'm drafting this to get feedback on the `<` to `<=` fix so far. I'll work on the conpty fix in the meantime
claunia added the pull-request label 2026-01-31 09:15:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26284
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?