starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Feature Request] A confirmation dialect window show up before closing the current tab. #2629

New Issue
Closed
opened 2026-01-30 23:00:33 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 23:00:33 +00:00
Owner
Copy Link

Originally created by @were on GitHub (Jul 8, 2019).

Summary of the new feature/enhancement

Is it possible, to implement something like this:
When there is an active process in the current tab, a confirmation dialect window may show up before actually closing.

When I was writing vim, I need to use C-W to switch among vim tabs.
C-W is also the hotkey to close the current tab.
When the first two times I ran into this problem, I suppose it was some crashing thing.
Finally, I realized it was a hotkey conflict.

Proposed technical implementation details (optional)

I did not dive into the code base of this project yet, but I hope it is not too hard to implement.

Originally created by @were on GitHub (Jul 8, 2019). # Summary of the new feature/enhancement Is it possible, to implement something like this: When there is an active process in the current tab, a confirmation dialect window may show up before actually closing. When I was writing vim, I need to use `C-W` to switch among vim tabs. `C-W` is also the hotkey to close the current tab. When the first two times I ran into this problem, I suppose it was some crashing thing. Finally, I realized it was a hotkey conflict. # Proposed technical implementation details (optional) I did not dive into the code base of this project yet, but I hope it is not too hard to implement.
claunia commented 2026-01-30 23:00:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 8, 2019):

This seems like a good feature request. I think we've mentioned it somewhere else in another thread, but this is a good setting. Something like:

"promptBeforeClosing": bool

or similar, to control whether the dialog appears or not. Or something like

"suppressCloseDialog": bool

and display the dialog by default when we notice there's more than one child* process attached to the terminal

*: not including conhost of course

@zadjii-msft commented on GitHub (Jul 8, 2019): This seems like a good feature request. I think we've mentioned it somewhere else in another thread, but this is a good setting. Something like: ```json "promptBeforeClosing": bool ``` or similar, to control whether the dialog appears or not. Or something like ```json "suppressCloseDialog": bool ``` and display the dialog by default when we notice there's more than one child\* process attached to the terminal \*: not including conhost of course
claunia commented 2026-01-30 23:00:34 +00:00
Author
Owner
Copy Link

@were commented on GitHub (Jul 9, 2019):

Is there any branch implementing this? If not, I can take it.

@were commented on GitHub (Jul 9, 2019): Is there any branch implementing this? If not, I can take it.
claunia commented 2026-01-30 23:00:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 9, 2019):

@were nope, not yet. Feel free to take a stab at it!

@zadjii-msft commented on GitHub (Jul 9, 2019): @were nope, not yet. Feel free to take a stab at it!
claunia commented 2026-01-30 23:00:35 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 6, 2019):

Hey so this was partially implemented in #2526, to resolve #1589.

There's also #2976, which tracks a follow-up to #2526 to connect more settings to the dialog. Since that issue seems to have a few more details, I'm going to close this one in favor of that one. Thanks!

/dup #1589
/dup #2976

@zadjii-msft commented on GitHub (Nov 6, 2019): Hey so this was partially implemented in #2526, to resolve #1589. There's also #2976, which tracks a follow-up to #2526 to connect more settings to the dialog. Since that issue seems to have a few more details, I'm going to close this one in favor of that one. Thanks! /dup #1589 /dup #2976
claunia commented 2026-01-30 23:00:35 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 6, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Nov 6, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Area-UserInterface Issue-Task Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2629
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?