starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5385] [MERGED] Fix a deadlock and a bounding rects issue in UIA #26300

New Issue
Open
opened 2026-01-31 09:15:12 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:15:12 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5385
Author: @DHowett-MSFT
Created: 4/17/2020
Status: ✅ Merged
Merged: 4/17/2020
Merged by: @undefined

Base: master ← Head: dev/duhowett/uia_fixes

📝 Commits (2)

  • db80275 uia: make bounding rects viewport-relative again
  • 01431af uia: unlock the read lock before triggering a scroll

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 src/types/UiaTextRangeBase.cpp (+6 -2)

📄 Description

The scroll locking rework that landed with the DxRenderer's partial
invalidation change introduced a deadlock. UIA locks the buffer for
reading before asking it to scroll (which now requires a write lock.)

Scrolling is probably okay to have a little bit of torn state that
might arise from us unlocking the read lock early before triggering the
write lock down the line.

While investigating this, I also noticed that our bounding rects stopped
being viewport-relative (and were instead buffer-relative.) That
regressed with the switch to GetTextRects in #4991

PR Checklist

  • Closes (issues noticed in investigating the DPI changes)
  • CLA signed.
  • Tests added/passed
  • Requires documentation to be updated
  • Core contributor badge

Validation Steps Performed

Manual pass with inspect.exe

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5385 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 4/17/2020 **Status:** ✅ Merged **Merged:** 4/17/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/duhowett/uia_fixes` --- ### 📝 Commits (2) - [`db80275`](https://github.com/microsoft/terminal/commit/db8027516e0ac36921503bd3afb498d27cdf2207) uia: make bounding rects viewport-relative again - [`01431af`](https://github.com/microsoft/terminal/commit/01431af01b149ad0ac386746b2487c09b339a8ed) uia: unlock the read lock before triggering a scroll ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/types/UiaTextRangeBase.cpp` (+6 -2) </details> ### 📄 Description The scroll locking rework that landed with the DxRenderer's partial invalidation change introduced a deadlock. UIA locks the buffer for reading before asking it to scroll (which now requires a write lock.) Scrolling is probably _okay_ to have a little bit of torn state that might arise from us unlocking the read lock early before triggering the write lock down the line. While investigating this, I also noticed that our bounding rects stopped being viewport-relative (and were instead buffer-relative.) That regressed with the switch to `GetTextRects` in #4991 ## PR Checklist * [ ] Closes (issues noticed in investigating the DPI changes) * [x] CLA signed. * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] Core contributor badge ## Validation Steps Performed Manual pass with inspect.exe --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26300
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?