[PR #5398] Don't duplicate spaces from potentially-wrapped EOL-deferred lines #26302

Open
opened 2026-01-31 09:15:13 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/5398

State: closed
Merged: Yes


The logic here, regarding deleting the spaces and just instantly adding
them bad, is incredibly suspect. Given that we're close to 0.11, I don't
think I can change it.

I've added a TODO with an issue number to figure out the right logic
here.

Fixes #5386.

PR Checklist

Validation Steps Performed

Tests, manual validation of the scenario in 5386 and a repro program.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/5398 **State:** closed **Merged:** Yes --- The logic here, regarding deleting the spaces and just instantly adding them bad, is incredibly suspect. Given that we're close to 0.11, I don't think I can change it. I've added a TODO with an issue number to figure out the right logic here. Fixes #5386. ## PR Checklist * [x] Closes #5386 * [x] CLA signed * [x] Tests added/passed * [ ] Requires documentation to be updated * [x] I'm horrified. ## Validation Steps Performed Tests, manual validation of the scenario in 5386 and a repro program.
claunia added the pull-request label 2026-01-31 09:15:13 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26302