starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5405] [CLOSED] Constrain a11y word nav to the virtual bottom #26307

New Issue
Open
opened 2026-01-31 09:15:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:15:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5405
Author: @carlos-zamora
Created: 4/18/2020
Status: ❌ Closed

Base: main ← Head: dev/cazamor/acc/ch/word-nav-perf

📝 Commits (4)

  • 6ecc28a Improve word navigation perf in ConHost
  • 66e9d73 remove unnecessary narrow
  • 76fcc51 change name of variable
  • 8169d16 Merge branch 'master' into dev/cazamor/acc/ch/word-nav-perf

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 src/host/renderData.cpp (+5 -2)

📄 Description

Use the virtual bottom in ConHost to speed up a11y word navigation performance. GetTextBufferEndPosition() is also used by by search; it'll also get a minor performance boost.

PR Checklist

Detailed Description of the Pull Request / Additional comments

#7789 uses GetLastNonspaceCharacter() to determine where the last word is and exit early on a UIA::Move by word call. The change in this PR passes the virtual bottom over to GetLastNonspaceCharacter() to make that search a bit faster.

Tested word navigation on Host.exe using NVDA.

WPR Traces

The percentages below represent the weight that a function call had. The
test scenario included moving by word on the CMD welcome message until
the last word was reached. Inspect.exe was used to limit any additional
calls that are generally performed by a screen reader.

function current branch
UIA:Move 29.52% 28.43%

There is an improvement of about 1% in a release build of ConHost.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5405 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 4/18/2020 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/cazamor/acc/ch/word-nav-perf` --- ### 📝 Commits (4) - [`6ecc28a`](https://github.com/microsoft/terminal/commit/6ecc28ab07b4013659b942c2b5c3285bb71516b7) Improve word navigation perf in ConHost - [`66e9d73`](https://github.com/microsoft/terminal/commit/66e9d731015427243065a29523eac5b5af69f10e) remove unnecessary narrow - [`76fcc51`](https://github.com/microsoft/terminal/commit/76fcc51952ed4fc8fe8c35258e2b227a3398fffc) change name of variable - [`8169d16`](https://github.com/microsoft/terminal/commit/8169d1649ba22576c12d8aaff324523ffce7e305) Merge branch 'master' into dev/cazamor/acc/ch/word-nav-perf ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/host/renderData.cpp` (+5 -2) </details> ### 📄 Description Use the virtual bottom in ConHost to speed up a11y word navigation performance. `GetTextBufferEndPosition()` is also used by by search; it'll also get a minor performance boost. ## PR Checklist * [X] Closes #5243 ## Detailed Description of the Pull Request / Additional comments #7789 uses `GetLastNonspaceCharacter()` to determine where the last word is and exit early on a `UIA::Move` by word call. The change in this PR passes the virtual bottom over to `GetLastNonspaceCharacter()` to make that search a bit faster. Tested word navigation on Host.exe using NVDA. ### WPR Traces The percentages below represent the weight that a function call had. The test scenario included moving by word on the CMD welcome message until the last word was reached. Inspect.exe was used to limit any additional calls that are generally performed by a screen reader. | function | current | branch | | -- | -- | -- | | `UIA:Move` | 29.52% | 28.43% | There is an improvement of about 1% in a release build of ConHost. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26307
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?