starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5413] [MERGED] ci: spelling: update to 0.0.15a; update whitelist #26309

New Issue
Open
opened 2026-01-31 09:15:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:15:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5413
Author: @jsoref
Created: 4/19/2020
Status: ✅ Merged
Merged: 4/21/2020
Merged by: @DHowett-MSFT

Base: master ← Head: spelling

📝 Commits (2)

📊 Changes

8 files changed (+9 additions, -71 deletions)

View changed files

📝 .github/actions/spell-check/dictionary/apis.txt (+1 -0)
📝 .github/actions/spell-check/dictionary/names.txt (+1 -0)
📝 .github/actions/spell-check/whitelist/alphabet.txt (+0 -3)
📝 .github/actions/spell-check/whitelist/whitelist.txt (+3 -64)
📝 .github/workflows/spelling.yml (+1 -1)
📝 src/cascadia/TerminalApp/App.idl (+1 -1)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+1 -1)
📝 src/tools/closetest/closetest.cpp (+1 -1)

📄 Description

Summary of the Pull Request

  • Cleaning up the whitelist a bit.

  • ⚠️ This check-spelling 0.0.15a+ tolerates Windows line endings in the whitelist.txt file (another project I touched had some .gitconfig magic which required supporting them).

    This means that if someone edits the file w/ something that likes Windows line endings, the file will successfully convert (instead of it being ignored and check-spelling complaining about everything). Most likely anyone else who then edits the file will use something that will maintain the line endings.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5413 **Author:** [@jsoref](https://github.com/jsoref) **Created:** 4/19/2020 **Status:** ✅ Merged **Merged:** 4/21/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `spelling` --- ### 📝 Commits (2) - [`817935a`](https://github.com/microsoft/terminal/commit/817935a9b61db5defa8694a1899f51ef2286c33c) spelling: AppLogic - [`3e42c9a`](https://github.com/microsoft/terminal/commit/3e42c9accc69abf64a2071b57705fd7f3cc49335) Update spell-check ### 📊 Changes **8 files changed** (+9 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spell-check/dictionary/apis.txt` (+1 -0) 📝 `.github/actions/spell-check/dictionary/names.txt` (+1 -0) 📝 `.github/actions/spell-check/whitelist/alphabet.txt` (+0 -3) 📝 `.github/actions/spell-check/whitelist/whitelist.txt` (+3 -64) 📝 `.github/workflows/spelling.yml` (+1 -1) 📝 `src/cascadia/TerminalApp/App.idl` (+1 -1) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+1 -1) 📝 `src/tools/closetest/closetest.cpp` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request * Cleaning up the whitelist a bit. * The magic to exclude repeated characters worked 👍 * Every successful run on master now logs its suggested cleanup, e.g. for https://github.com/microsoft/terminal/commit/5740e197c20bea97b0afe4b396d0541691d02b2c has https://github.com/microsoft/terminal/runs/596271627#step:4:37 * ⚠️ This check-spelling 0.0.15a+ tolerates Windows line endings in the `whitelist.txt` file (another project I touched had some `.gitconfig` magic which required supporting them). This means that if someone edits the file w/ something that likes Windows line endings, the file will successfully convert (instead of it being ignored and check-spelling complaining about everything). Most likely anyone else who then edits the file will use something that will maintain the line endings. ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26309
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?