[PR #5457] [MERGED] Use string_view where possible #26325

Open
opened 2026-01-31 09:15:22 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5457
Author: @rongjiecomputer
Created: 4/22/2020
Status: Merged
Merged: 4/22/2020
Merged by: @miniksa

Base: masterHead: patch-1


📝 Commits (1)

  • 1684169 Use string_view where possible

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/renderer/vt/VtSequences.cpp (+2 -2)

📄 Description

_Write accepts std::string_view, so don't create std::string for const string.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5457 **Author:** [@rongjiecomputer](https://github.com/rongjiecomputer) **Created:** 4/22/2020 **Status:** ✅ Merged **Merged:** 4/22/2020 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`1684169`](https://github.com/microsoft/terminal/commit/1684169ae0121f0ce3dd48615ffdba3d3b018191) Use string_view where possible ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/renderer/vt/VtSequences.cpp` (+2 -2) </details> ### 📄 Description `_Write` accepts `std::string_view`, so don't create `std::string` for const string. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:22 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26325