starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5508] [MERGED] Add a Third-Party notices link to the about dialog #26345

New Issue
Open
opened 2026-01-31 09:15:29 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:15:29 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5508
Author: @leonMSFT
Created: 4/23/2020
Status: ✅ Merged
Merged: 4/28/2020
Merged by: @undefined

Base: master ← Head: dev/lelian/otherwisewegetsuedmaybe

📝 Commits (10+)

📊 Changes

7 files changed (+44 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+4 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+8 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.idl (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+3 -0)
📝 src/cascadia/TerminalApp/lib/TerminalAppLib.vcxproj (+4 -0)
➕ tools/GenerateCommitHashHeader.ps1 (+21 -0)

📄 Description

Summary of the Pull Request

This PR will add a link to the version of NOTICE.md in GitHub at the commit that the build was on. It uses the same approach for generating our settings files, where we'll create a header file with the commit hash assigned to a wstring_view during build time.

PR Checklist

Validation Steps Performed

The link is there and goes to the expected NOTICE.md.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5508 **Author:** [@leonMSFT](https://github.com/leonMSFT) **Created:** 4/23/2020 **Status:** ✅ Merged **Merged:** 4/28/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/lelian/otherwisewegetsuedmaybe` --- ### 📝 Commits (10+) - [`e25f517`](https://github.com/microsoft/terminal/commit/e25f5171ade2182886646ee8866b2a828da9bbfa) now we won't get sued maybe - [`a25280e`](https://github.com/microsoft/terminal/commit/a25280e520c3d1a9cb636b6bb544e6e6d8b6eec5) adding newline - [`df7c104`](https://github.com/microsoft/terminal/commit/df7c104daf04e3e7e908d50e339b1f02a13d3c57) merging from master - [`b6d5e3e`](https://github.com/microsoft/terminal/commit/b6d5e3ecb2457d2942d209bc018c7707074330d4) wtf are these changes i've never seen before - [`3e4f743`](https://github.com/microsoft/terminal/commit/3e4f7430b048d80b2c7b141270c2a53728a6ad31) format - [`6872f8f`](https://github.com/microsoft/terminal/commit/6872f8f45a1a98fd5af5b899224d2615c9c890d3) get these changes out of my face - [`ca228a8`](https://github.com/microsoft/terminal/commit/ca228a818d077c1d60c17e219a05df40eeaf4cc4) comment to keep sane - [`7e33849`](https://github.com/microsoft/terminal/commit/7e3384917993977492f17ef8475dabc0cda7bf54) hyphen is right i think - [`223bf6d`](https://github.com/microsoft/terminal/commit/223bf6d138ad11a45a108caf0c4d9e24a2f639cf) cleanup - [`7adfd5d`](https://github.com/microsoft/terminal/commit/7adfd5d2a0676ef14ba8400b8e185ded5891da22) spellcheck ### 📊 Changes **7 files changed** (+44 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+4 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+8 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.idl` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+3 -0) 📝 `src/cascadia/TerminalApp/lib/TerminalAppLib.vcxproj` (+4 -0) ➕ `tools/GenerateCommitHashHeader.ps1` (+21 -0) </details> ### 📄 Description ## Summary of the Pull Request This PR will add a link to the version of `NOTICE.md` in GitHub at the commit that the build was on. It uses the same approach for generating our settings files, where we'll create a header file with the commit hash assigned to a `wstring_view` during build time. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #5139 * [x] CLA signed. * [x] Tests added/passed <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed The link is there and goes to the expected `NOTICE.md`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26345
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?