[PR #5599] [MERGED] Add and enforce minimum width #26387

Open
opened 2026-01-31 09:15:45 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5599
Author: @carlos-zamora
Created: 4/27/2020
Status: Merged
Merged: 4/29/2020
Merged by: @undefined

Base: masterHead: dev/cazamor/a11y/resize


📝 Commits (4)

  • 42fc183 Add minimum size to Terminal
  • 0711c0a 460x380 min size
  • a82c90f shoutout to Michael for this pair programming
  • bc55dae remove minimum height restriction

📊 Changes

2 files changed (+10 additions, -0 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+6 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+4 -0)

📄 Description

Summary of the Pull Request

Enforces a minimum width of 460 wide. This allows tabs to always be seen (albeit partially).

NOTE: A minimum height was originally added to allow the About menu to be seen. This minimum height was removed from this PR because we don't foresee a circumstance where your Terminal is in that state, and you can't just resize it to make the content fit properly.

References

#4990 may be fixed/affected by this?

PR Checklist

Validation Steps Performed

Here's some images of what the terminal looks like when it's at its minimum size:

100% scaling

100% scaling: one tab

100% scaling: one tab

100% scaling: two tabs

100% scaling: two tabs

100% scaling: 3 tabs (scrolling enabled)

100% scaling: 3 tabs (scrolling enabled)

200% scaling

200% scaling: one tab

200% scaling: one tab

200% scaling: two tabs

200% scaling: two tabs

200% scaling: 3 tabs (scrolling enabled)

200% scaling: 3 tabs (scrolling enabled)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5599 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 4/27/2020 **Status:** ✅ Merged **Merged:** 4/29/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/cazamor/a11y/resize` --- ### 📝 Commits (4) - [`42fc183`](https://github.com/microsoft/terminal/commit/42fc1832a2dbba9ef202368cbfb0f6a8dc15ac53) Add minimum size to Terminal - [`0711c0a`](https://github.com/microsoft/terminal/commit/0711c0a1a362d993df84088dc62eebcbc3c3938a) 460x380 min size - [`a82c90f`](https://github.com/microsoft/terminal/commit/a82c90fd18263291b43d2075c135f86528c9f069) shoutout to Michael for this pair programming - [`bc55dae`](https://github.com/microsoft/terminal/commit/bc55daecc6ab967dc516c9f9677b04d52a9849b7) remove minimum height restriction ### 📊 Changes **2 files changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+6 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+4 -0) </details> ### 📄 Description ## Summary of the Pull Request Enforces a minimum width of 460 wide. This allows tabs to always be seen (albeit partially). NOTE: A minimum height was originally added to allow the About menu to be seen. This minimum height was removed from this PR because we don't foresee a circumstance where your Terminal is in that state, and you can't just resize it to make the content fit properly. ## References #4990 may be fixed/affected by this? ## PR Checklist * [X] Closes #4976 * [X] Will close issue #5418 upon verification ## Validation Steps Performed Here's some images of what the terminal looks like when it's at its minimum size: ### 100% scaling #### 100% scaling: one tab ![100% scaling: one tab](https://user-images.githubusercontent.com/11050425/80408686-76e0fd00-887c-11ea-8283-35871d24652a.png) #### 100% scaling: two tabs ![100% scaling: two tabs](https://user-images.githubusercontent.com/11050425/80408695-79435700-887c-11ea-9670-116cde320e07.png) #### 100% scaling: 3 tabs (scrolling enabled) ![100% scaling: 3 tabs (scrolling enabled)](https://user-images.githubusercontent.com/11050425/80408701-7c3e4780-887c-11ea-8ede-8b69d20d6f66.png) ### 200% scaling #### 200% scaling: one tab ![200% scaling: one tab](https://user-images.githubusercontent.com/11050425/80408783-9a0bac80-887c-11ea-8b62-bd064f89403d.png) #### 200% scaling: two tabs ![200% scaling: two tabs](https://user-images.githubusercontent.com/11050425/80408793-9c6e0680-887c-11ea-9301-344189281006.png) #### 200% scaling: 3 tabs (scrolling enabled) ![200% scaling: 3 tabs (scrolling enabled)](https://user-images.githubusercontent.com/11050425/80408799-9ed06080-887c-11ea-892a-ee8e329080c5.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:45 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26387