[PR #5598] [MERGED] Improve default foregrounds for Tango schemes #26388

Open
opened 2026-01-31 09:15:45 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5598
Author: @rkitover
Created: 4/27/2020
Status: ✅ Merged
Merged: 4/27/2020
Merged by: @DHowett-MSFT

Base: master ← Head: tango-followup


📝 Commits (1)

  • fdd30f3 Better default foreground for Tango colors.

📊 Changes

3 files changed (+8 additions, -8 deletions)

View changed files

📝 src/cascadia/TerminalApp/defaults.json (+2 -2)
📝 src/tools/ColorTool/schemes/tango_dark.itermcolors (+3 -3)
📝 src/tools/ColorTool/schemes/tango_light.itermcolors (+3 -3)

📄 Description

Followup on ea61aa3b.

The default foreground in the iTerm2 defaults for the Tango Dark color
scheme is too bright, use the value for ANSI 7 (white) instead.

Signed-off-by: Rafael Kitover rkitover@gmail.com

References

#5305

PR Checklist

  • Closes #xxx
  • [x ] CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Sorry, I should have really done this in the original PR.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5598 **Author:** [@rkitover](https://github.com/rkitover) **Created:** 4/27/2020 **Status:** ✅ Merged **Merged:** 4/27/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `tango-followup` --- ### 📝 Commits (1) - [`fdd30f3`](https://github.com/microsoft/terminal/commit/fdd30f38f747d9e16acc6a47d7b5f0092821d560) Better default foreground for Tango colors. ### 📊 Changes **3 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/defaults.json` (+2 -2) 📝 `src/tools/ColorTool/schemes/tango_dark.itermcolors` (+3 -3) 📝 `src/tools/ColorTool/schemes/tango_light.itermcolors` (+3 -3) </details> ### 📄 Description Followup on ea61aa3b. The default foreground in the iTerm2 defaults for the Tango Dark color scheme is too bright, use the value for ANSI 7 (white) instead. Signed-off-by: Rafael Kitover <rkitover@gmail.com> ## References #5305 ## PR Checklist * [ ] Closes #xxx * [x ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx Sorry, I should have really done this in the original PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:45 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26388