starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5630] [MERGED] Clamp the new rows scrolling value to a positive number #26396

New Issue
Open
opened 2026-01-31 09:15:49 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:15:49 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5630
Author: @zadjii-msft
Created: 4/28/2020
Status: ✅ Merged
Merged: 4/29/2020
Merged by: @undefined

Base: master ← Head: dev/migrie/b/i-have-no-idea-what-this-is

📝 Commits (3)

  • cfeaf54 Well this is definitely wrong
  • ba447fb Adding a test for this was sure the roller coaster
  • 84b01c2 good bot

📊 Changes

5 files changed (+195 additions, -4 deletions)

View changed files

📝 src/cascadia/TerminalCore/Terminal.cpp (+7 -3)
📝 src/cascadia/TerminalCore/Terminal.hpp (+2 -0)
➕ src/cascadia/UnitTests_TerminalCore/TerminalAndRendererTests.cpp (+177 -0)
📝 src/cascadia/UnitTests_TerminalCore/TerminalBufferTests.cpp (+8 -1)
📝 src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj (+1 -0)

📄 Description

Summary of the Pull Request

This PR clamp the "new rows" scrolling value to a positive number. We can't create a negative number of new rows. It also adds a test.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

The origin of this bug is that as newlines are emitted, we'll accumulate an enormous scroll delta into a selection region, to the point of overflowing a SHORT. When the overflow occurs, the Terminal would fail to send a NotifyScroll() to the TermControl hosting it.

For this bug to repro, we need to:

  • Have a sufficiently large buffer, because each newline we'll accumulate a delta of (0, ~bufferHeight), so (bufferHeight^2 + bufferHeight) > SHRT_MAX
  • Have a selection

Validation Steps Performed

  • Dustin verified this actually
  • Created a new insane test case

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5630 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/28/2020 **Status:** ✅ Merged **Merged:** 4/29/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/i-have-no-idea-what-this-is` --- ### 📝 Commits (3) - [`cfeaf54`](https://github.com/microsoft/terminal/commit/cfeaf54cca990c768d6889963fc8a10bfbc1179d) Well this is definitely wrong - [`ba447fb`](https://github.com/microsoft/terminal/commit/ba447fb95f3dcf1fce78091f316b829226da644f) Adding a test for this was sure the roller coaster - [`84b01c2`](https://github.com/microsoft/terminal/commit/84b01c24182be5235bf603431135943f92356d0f) good bot ### 📊 Changes **5 files changed** (+195 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+7 -3) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+2 -0) ➕ `src/cascadia/UnitTests_TerminalCore/TerminalAndRendererTests.cpp` (+177 -0) 📝 `src/cascadia/UnitTests_TerminalCore/TerminalBufferTests.cpp` (+8 -1) 📝 `src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request This PR clamp the "new rows" scrolling value to a positive number. We can't create a negative number of new rows. It also adds a test. ## References ## PR Checklist * [x] Closes #5540 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments The origin of this bug is that as newlines are emitted, we'll accumulate an enormous scroll delta into a selection region, to the point of overflowing a `SHORT`. When the overflow occurs, the `Terminal` would fail to send a `NotifyScroll()` to the `TermControl` hosting it. For this bug to repro, we need to: - Have a sufficiently large buffer, because each newline we'll accumulate a delta of (0, ~bufferHeight), so (bufferHeight^2 + bufferHeight) > SHRT_MAX - Have a selection ## Validation Steps Performed * Dustin verified this actually * Created a new insane test case --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26396
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?