starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #5652] [MERGED] Add explicit identifier to some constructors #26405

New Issue
Open
opened 2026-01-31 09:15:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:15:52 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/5652
Author: @ghost
Created: 4/29/2020
Status: ✅ Merged
Merged: 4/30/2020
Merged by: @DHowett-MSFT

Base: master ← Head: explicit

📝 Commits (1)

📊 Changes

11 files changed (+12 additions, -11 deletions)

View changed files

📝 src/cascadia/TerminalApp/ActionArgs.h (+2 -1)
📝 src/cascadia/TerminalApp/CascadiaSettings.h (+1 -1)
📝 src/cascadia/TerminalApp/DebugTapConnection.h (+1 -1)
📝 src/cascadia/TerminalApp/Pane.h (+1 -1)
📝 src/cascadia/TerminalApp/Profile.h (+1 -1)
📝 src/cascadia/TerminalApp/TerminalWarnings.h (+1 -1)
📝 src/cascadia/TerminalAzBridge/ConsoleInputReader.h (+1 -1)
📝 src/host/CommandNumberPopup.hpp (+1 -1)
📝 src/host/CopyFromCharPopup.hpp (+1 -1)
📝 src/host/conareainfo.h (+1 -1)
📝 src/host/conattrs.cpp (+1 -1)

📄 Description

Summary of the Pull Request

If a class has a constructor which can be called with a single argument, then this constructor becomes conversion constructor because such a constructor allows conversion of the single argument to the class being constructed. To ensure these constructors are passed the argument of its type, I labeled them explicit.

References

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed

Detailed Description of the Pull Request / Additional comments

In some header files, there were constructors that took a value that could involve implicit conversions, so I added explicit to ensure that does not happen.

Validation Steps Performed

Unit testing

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/5652 **Author:** [@ghost](https://github.com/ghost) **Created:** 4/29/2020 **Status:** ✅ Merged **Merged:** 4/30/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `explicit` --- ### 📝 Commits (1) - [`d8c1149`](https://github.com/microsoft/terminal/commit/d8c11499f6f5c0e37c5c3323e3d05d4b0a357104) Add explicit identifier ### 📊 Changes **11 files changed** (+12 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+2 -1) 📝 `src/cascadia/TerminalApp/CascadiaSettings.h` (+1 -1) 📝 `src/cascadia/TerminalApp/DebugTapConnection.h` (+1 -1) 📝 `src/cascadia/TerminalApp/Pane.h` (+1 -1) 📝 `src/cascadia/TerminalApp/Profile.h` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalWarnings.h` (+1 -1) 📝 `src/cascadia/TerminalAzBridge/ConsoleInputReader.h` (+1 -1) 📝 `src/host/CommandNumberPopup.hpp` (+1 -1) 📝 `src/host/CopyFromCharPopup.hpp` (+1 -1) 📝 `src/host/conareainfo.h` (+1 -1) 📝 `src/host/conattrs.cpp` (+1 -1) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request If a class has a constructor which can be called with a single argument, then this constructor becomes conversion constructor because such a constructor allows conversion of the single argument to the class being constructed. To ensure these constructors are passed the argument of its type, I labeled them explicit. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [X] Tests added/passed <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments In some header files, there were constructors that took a value that could involve implicit conversions, so I added explicit to ensure that does not happen. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Unit testing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:15:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#26405
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?